Skip to content

Commit 5971051

Browse files
author
hornik
committed
Download revdeps in parallel (PR#18976, by Mikael Jagan).
git-svn-id: https://svn.r-project.org/R/trunk@89126 00db46b3-68df-0310-9c12-caf00c1e9a41
1 parent 7ec3cb4 commit 5971051

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

src/library/tools/R/checktools.R

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -220,17 +220,27 @@ function(dir,
220220
available[pos, "Version"])
221221

222222
if(length(rfiles)) {
223-
message("downloading reverse dependencies ...")
223+
msg <- gettextf("downloading reverse dependencies %s",
224+
paste(sQuote(rnames), collapse = ", "))
225+
msg <- paste(strwrap(msg, exdent = 2L), collapse = "\n")
226+
message(msg, "\n", domain = NA)
224227
rfurls <- sprintf("%s/%s",
225228
available[pos, "Repository"],
226229
rfiles)
227-
for(i in seq_along(rfiles)) {
228-
message(sprintf("downloading %s ... ", rfiles[i]),
229-
appendLF = FALSE)
230-
status <- if(!utils::download.file(rfurls[i], rfiles[i],
231-
quiet = TRUE))
232-
"ok" else "failed"
233-
message(status)
230+
status <- utils::download.file(rfurls, rfiles,
231+
method = "libcurl",
232+
mode = "wb")
233+
if(status != 0L || any(rv <- attr(status, "retvals"))) {
234+
fails <- if(status != 0L) rnames else rnames[rv != 0L]
235+
n <- length(fails)
236+
msg <-
237+
if(n == 1L)
238+
gettextf("download of reverse dependency %s failed",
239+
sQuote(fails))
240+
else
241+
gettextf("download of %d reverse dependencies failed:\n %s",
242+
n, paste(sQuote(fails), collapse = ", "))
243+
message(msg, domain = NA)
234244
}
235245
message("")
236246
}

0 commit comments

Comments
 (0)