update implicitGeneric toeplitz(): default has 3 args now

git-svn-id: https://svn.r-project.org/R/trunk@89146 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: maechler

doc/NEWS.Rd

@@ -448,6 +448,10 @@
       \item Subassignment, \code{x[ind] <- val}, to 1-dimensional
       \code{array}s no longer \dQuote{drops} them to simple vectors when
       \code{ind} is a name, fixing \PR{18973}, reported by \I{Thomas Soeiro}.
+
+      \item The implicitGeneric definition for \code{toeplitz()} produced a
+      default method that failed when \code{toeplitz(x, r)} was called with
+      more than the first argument.  Simple fix from \I{Mikael Jagan}.
     }
   }
 }

src/library/methods/R/makeBasicFunsList.R

@@ -1,7 +1,7 @@
 #  File src/library/methods/R/makeBasicFunsList.R
 #  Part of the R package, https://www.R-project.org
 #
-#  Copyright (C) 1995-2024 The R Core Team
+#  Copyright (C) 1995-2025 The R Core Team
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -279,7 +279,7 @@ utils::globalVariables(".addBasicGeneric")
 
     ## our toeplitz() only has 'x'; want the generic "here" rather than "out there"
     setGeneric("toeplitz", function(x, ...) standardGeneric("toeplitz"),
-	       useAsDefault= function(x, ...) stats::toeplitz(x),
+	       useAsDefault = function(x, ...) stats::toeplitz(x, ...),
 	       signature = "x", where = where)
     setGenericImplicit("toeplitz", where, FALSE)
 

src/library/stats/R/diffinv.R

@@ -26,16 +26,15 @@ diffinv.vector <- function (x, lag = 1L, differences = 1L, xi, ...)
     if (!is.vector(x)) stop ("'x' is not a vector")
     lag <- as.integer(lag); differences <- as.integer(differences)
     if (lag < 1L || differences < 1L) stop ("bad value for 'lag' or 'differences'")
-    if(missing(xi)) xi <- rep(0., lag*differences)
-    if (length(xi) != lag*differences)
+    if(missing(xi))
+        xi <- rep(0., lag*differences)
+    else if (length(xi) != lag*differences)
         stop("'xi' does not have the right length")
     if (differences == 1L) {
         x <- as.double(x)
         xi <- as.double(xi)
         n <- as.integer(length(x))
         if(is.na(n)) stop(gettextf("invalid value of %s", "length(x)"), domain = NA)
-#        y <- c(xi[1L:lag], double(n))
-#        z <- .C(C_R_intgrt_vec, x, y = y, as.integer(lag), n)$y
         .Call(C_intgrt_vec, x, xi, lag)
     }
     else

tests/classes-methods.R

@@ -219,5 +219,16 @@ B <- as(new("A"), "B") ## gave  Error in asMethod@generic :  ... `@` applied to
 stopifnot(identical(B, new("B")))
 
 
+## toeplitz() implicit generic
+x <- c(-1, 0,0)
+r <- c(-1,11,0)
+(T3 <- toeplitz(x, r))
+## dummy method triggering (implicit) creation of S4 generic and default
+setMethod("toeplitz", "A", function(x, ...) x)
+ (mm <- selectMethod(toeplitz, "numeric"))
+stopifnot(identical(T3, print(toeplitz(x, r))), removeGeneric("toeplitz"))
+## badly failed since r82364 when stats::toeplitz was generalized to 3 args
+
+
 
 cat('Time elapsed: ', proc.time(),'\n')