someone might edit an autconf script to use /bin/bash

git-svn-id: https://svn.r-project.org/R/trunk@87497 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: ripley

src/library/tools/R/check.R

@@ -1395,6 +1395,28 @@ add_dummies <- function(dir, Log)
         ## checkbashisms skips non-shell scripts, and bash ones with a message.
         if (config_val_to_logical(Sys.getenv("_R_CHECK_BASHISMS_", "FALSE"))
             && any(file.exists("configure", "cleanup"))) {
+            for (f in c("configure", "cleanup")) {
+                ## /bin/bash is not portable
+                if (file.exists(f) &&
+                    any(grepl("^#! */bin/bash",
+                              readLines(f, 1L, warn = FALSE)))) {
+                    if(!any) {
+                        any <- TRUE
+                        msg <- paste0(sQuote(f), ": /bin/bash is not portable")
+                        noteLog(Log, msg)
+                    }
+                }
+                ## and bash need not be installed at all.
+                if (file.exists(f) &&
+                    any(grepl("^#!.*env bash",
+                              readLines(f, 1L, warn = FALSE)))) {
+                    if(!any) {
+                        any <- TRUE
+                        msg <- paste0(sQuote(f), ": 'env bash' is not portable as bash need not be installed")
+                        noteLog(Log, msg)
+                    }
+                }
+            }
             if (!nzchar(Sys.which("checkbashisms"))) {
                 if(!any) {
                     any <- TRUE
@@ -1406,26 +1428,6 @@ add_dummies <- function(dir, Log)
                         "in the 'Writing R Extensions' manual.\n")
             } else {
                 for (f in c("configure", "cleanup")) {
-                    ## /bin/bash is not portable
-                    if (file.exists(f) &&
-                        any(grepl("^#! */bin/bash",
-                                  readLines(f, 1L, warn = FALSE)))) {
-                        if(!any) {
-                            any <- TRUE
-                            msg <- paste0(sQuote(f), ": /bin/bash is not portable")
-                            noteLog(Log, msg)
-                        }
-                    }
-                    ## and bash need not be installed at all.
-                    if (file.exists(f) &&
-                        any(grepl("^#!.*env bash",
-                                  readLines(f, 1L, warn = FALSE)))) {
-                        if(!any) {
-                            any <- TRUE
-                            msg <- paste0(sQuote(f), ": 'env bash' is not portable as bash need not be installed")
-                            noteLog(Log, msg)
-                        }
-                    }
                     ## skip autoconf scripts as checkbashisms warns on system parts
                     if (file.exists(f) &&
                         !any(grepl("Generated by GNU Autoconf",