Skip to content

Commit 7c8a9c5

Browse files
author
smeyer
committed
checkDocFiles() for unaliased usages also in <pkg>-deprecated overviews
git-svn-id: https://svn.r-project.org/R/trunk@87273 00db46b3-68df-0310-9c12-caf00c1e9a41
1 parent 7b80b5e commit 7c8a9c5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

doc/NEWS.Rd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,8 @@
277277
Strings markaed as \code{"bytes"} now give a warning rather than a
278278
NOTE. These are better supplied as raw vectors.
279279
280-
\item \code{tools::checkDocFiles()} now also notes \emph{nullary}
281-
functions shown in the usage section without corresponding \verb{\alias}.
280+
\item \code{tools::checkDocFiles()} notes more cases of
281+
usage documentation without corresponding \verb{\alias}.
282282
}
283283
}
284284

src/library/tools/R/QC.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,12 +1526,12 @@ function(package, dir, lib.loc = NULL, chkInternal = NULL)
15261526
}
15271527

15281528
## Also test whether the objects we found from the \usage all
1529-
## have aliases, provided no alias ends in '-deprecated'.
1529+
## have aliases, provided not all aliases end in '-deprecated'.
15301530
## This exception allows packages to keep the original help page of a
15311531
## deprecated function at help("<fun>-deprecated") (see ?deprecated)
15321532
## and alias <fun> to help("<pkg>-deprecated").
15331533
functions_not_in_aliases <-
1534-
if(!any(endsWith(aliases, "-deprecated"))) {
1534+
if(!all(endsWith(aliases, "-deprecated"))) {
15351535
## Argh. There are good reasons for keeping \S4method{}{}
15361536
## as is, but of course this is not what the aliases use ...
15371537
## <FIXME>

0 commit comments

Comments
 (0)