hist(.., log="x") now works without warning

git-svn-id: https://svn.r-project.org/R/trunk@88435 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: maechler

doc/NEWS.Rd

@@ -231,6 +231,9 @@
 
       \item An initial newline inside an Rd inline \verb{\eqn} no longer
       breaks the paragraph in plain-text help (\code{tools::Rd2txt}).
+
+      \item \code{hist(*, log = "x")} now works without a warning, thanks
+      to \I{Martin Smith}'s \PR{18921}.
     }
   }
 }

src/library/graphics/R/hist.R

@@ -1,7 +1,7 @@
 #  File src/library/graphics/R/hist.R
 #  Part of the R package, https://www.R-project.org
 #
-#  Copyright (C) 1995-2021 The R Core Team
+#  Copyright (C) 1995-2025 The R Core Team
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -169,7 +169,7 @@ plot.histogram <-
 	      main = paste("Histogram of", paste(x$xname, collapse="\n")),
               sub = NULL,
 	      xlab = x$xname, ylab,
-	      xlim = range(x$breaks), ylim = NULL,
+	      xlim = range(x$breaks), ylim = NULL, log = "",
 	      axes = TRUE, labels = FALSE, add = FALSE, ann = TRUE, ...)
 {
     equidist <-
@@ -189,7 +189,7 @@ plot.histogram <-
 	if (missing(ylab))
 	    ylab <- if (!freq) "Density" else "Frequency"
 	plot.new()
-	plot.window(xlim, ylim, "", ...)	#-> ylim's default from 'y'
+	plot.window(xlim, ylim, log, ...)	#-> ylim's default from 'y'
 	if(ann) title(main = main, sub = sub, xlab = xlab, ylab = ylab, ...)
 	if(axes) {
 	    axis(1, ...)

src/library/graphics/man/hist.Rd

@@ -1,6 +1,6 @@
 % File src/library/graphics/man/hist.Rd
 % Part of the R package, https://www.R-project.org
-% Copyright 1995-2022 R Core Team
+% Copyright 1995-2025 R Core Team
 % Distributed under GPL 2 or later
 
 \name{hist}
@@ -70,8 +70,8 @@ hist(x, \dots)
   \item{xlim, ylim}{the range of x and y values with sensible defaults.
     Note that \code{xlim} is \emph{not} used to define the histogram (breaks),
     but only for plotting (when \code{plot = TRUE}).}
-  \item{axes}{logical.  If \code{TRUE} (default), axes are draw if the
-    plot is drawn.}
+  \item{log}{a string, by default \code{""}, otherwise typically \code{"x"}.}
+  \item{axes}{logical.  If \code{TRUE} (default), axes are drawn when the plot is.}
   \item{plot}{logical.  If \code{TRUE} (default), a histogram is
     plotted, otherwise a list of breaks and counts is returned.  In the
     latter case, a warning is used if (typically graphical) arguments

tests/reg-tests-1e.R

@@ -2046,6 +2046,13 @@ fixInNamespace("toRd.default", "tools", editor = function (...) omethod)
 assertValueIs("1")
 
 
+## No warnings for hist(.., log="x") -- PR#18921
+op <- options(warn = 2)
+hist(1:100, breaks = 2^(0:8), log = "x")
+options(op)
+## used to signal 3 warnings
+
+
 
 ## keep at end
 rbind(last =  proc.time() - .pt,