Skip to content

Commit 9a32d6b

Browse files
author
ripley
committed
flip defailt for reporting marked character strings
git-svn-id: https://svn.r-project.org/R/trunk@87261 00db46b3-68df-0310-9c12-caf00c1e9a41
1 parent 9414e46 commit 9a32d6b

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

doc/NEWS.Rd

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,12 @@
267267
\command{gfortran -Wall}. For hints on how to modernize these,
268268
see
269269
\url{https://fortranwiki.org/fortran/show/Modernizing+Old+Fortran}.
270+
271+
\item Since all supported \R versions now use UTF-8, \command{R CMD
272+
check} no longer by default reports on marked strings in
273+
character data. Set environment variable
274+
\env{_R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES_}
275+
to a false value for the previous behaviour.
270276
}
271277
}
272278

doc/manual/R-ints.texi

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4514,6 +4514,13 @@ Default: unset (but true for CRAN submission checks).
45144514
If set to a true value, check whether Rd cross-references to targets not
45154515
in the package itself or the base packages have package anchors.
45164516
Default: false (but true for CRAN submission checks).
4517+
4518+
@item _R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES_
4519+
If false report the use of non-ASCII
4520+
strings marked as UTF-8, Latin-1 or @code{"bytes"} as part of
4521+
@samp{checking data for non-ASCII characters}. Non-ASCII strings of
4522+
unknown encoding are always reported.
4523+
Default: true, but false prior on @R{} 4.5.0.
45174524
@end vtable
45184525

45194526
The following variables control checks for undeclared/unconditional use

src/library/tools/R/QC.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4969,7 +4969,7 @@ function(x, ...)
49694969

49704970
suppress_notes <-
49714971
config_val_to_logical(Sys.getenv("_R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES_",
4972-
"FALSE"))
4972+
"TRUE"))
49734973

49744974
c(character(),
49754975
if((n <- x$latin1) && !suppress_notes) {
@@ -7952,7 +7952,7 @@ function(dir, localOnly = FALSE, pkgSize = NA)
79527952
collapse = "\n")
79537953
}
79547954
}
7955-
7955+
79567956
skip_dates <-
79577957
config_val_to_logical(Sys.getenv("_R_CHECK_CRAN_INCOMING_SKIP_DATES_",
79587958
"FALSE"))
@@ -10342,7 +10342,7 @@ function(x, ...)
1034210342

1034310343
### ** .bad_DESCRIPTION_URL_field_parts
1034410344

10345-
.bad_DESCRIPTION_URL_field_parts <-
10345+
.bad_DESCRIPTION_URL_field_parts <-
1034610346
function(s)
1034710347
{
1034810348
if(is.na(s)) return(character())
@@ -10356,7 +10356,7 @@ function(s)
1035610356
z[!grepl("^<?(svn://|doi:)", z)]
1035710357
}
1035810358
}
10359-
10359+
1036010360

1036110361
### Local variables: ***
1036210362
### mode: outline-minor ***

0 commit comments

Comments
 (0)