start cleaning up use of Rboolean

git-svn-id: https://svn.r-project.org/R/trunk@87773 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: ripley

src/nmath/pnchisq.c

@@ -11,13 +11,13 @@
  *    distribution function. Appl.Statist., 41, 478-482.
 
  *  Other parts
- *  Copyright (C) 2000-2019  The R Core Team
+ *  Copyright (C) 2000-2025  The R Core Team
  *  Copyright (C) 2003-2015  The R Foundation
  */
 
 
 
-#include "nmath.h"
+#include "nmath.h" // declares pnchisq_raw
 #include "dpq.h"
 
 /*----------- DEBUGGING -------------
@@ -42,7 +42,7 @@
 static const double _dbl_min_exp = M_LN2 * DBL_MIN_EXP;
 /*= -708.3964 for IEEE double precision */
 
-
+/* This is the public interface in Rmath.h, so has to use 'int' */
 double pnchisq(double x, double df, double ncp, int lower_tail, int log_p)
 {
     double ans;
@@ -55,7 +55,8 @@ double pnchisq(double x, double df, double ncp, int lower_tail, int log_p)
 
     if (df < 0. || ncp < 0.) ML_WARN_return_NAN;
 
-    ans = pnchisq_raw(x, df, ncp, 1e-12, 8*DBL_EPSILON, 1000000, lower_tail, log_p);
+    ans = pnchisq_raw(x, df, ncp, 1e-12, 8*DBL_EPSILON, 1000000,
+		      (Rboolean) lower_tail, (Rboolean) log_p);
 
     if (x <= 0. || x == ML_POSINF)
 	return ans; // because it's perfect
@@ -86,6 +87,7 @@ double pnchisq(double x, double df, double ncp, int lower_tail, int log_p)
     }
 }
 
+// Used in this file and in qnchisq.c
 double attribute_hidden
 pnchisq_raw(double x, double f, double theta /* = ncp */,
 	    double errmax, double reltol, int itrmax,

src/nmath/qbeta.c

@@ -1,6 +1,6 @@
 /*
  *  R : A Computer Language for Statistical Data Analysis
- *  Copyright (C) 1998--2022  The R Core Team
+ *  Copyright (C) 1998--2025  The R Core Team
  *  Copyright (C) 1995, 1996  Robert Gentleman and Ross Ihaka
  *  based on code (C) 1979 and later Royal Statistical Society
  *
@@ -53,9 +53,11 @@
 
 //attribute_hidden
 static void
-qbeta_raw(double alpha, double p, double q, int lower_tail, int log_p,
+qbeta_raw(double alpha, double p, double q,
+	  Rboolean lower_tail, Rboolean log_p,
 	  int swap_01, double log_q_cut, int n_N, double* qb);
 
+/* This is the public interface in Rmath.h, so has to use 'int' */
 double qbeta(double alpha, double p, double q, int lower_tail, int log_p)
 {
 
@@ -109,8 +111,12 @@ static const double
 #define const4 0.04481
 
 // Returns both qbeta() and its "mirror" 1-qbeta(). Useful notably when qbeta() ~= 1
-attribute_hidden void
-qbeta_raw(double alpha, double p, double q, int lower_tail, int log_p,
+// This was hidden, but it is only used in this file so could be static
+// and be simplifed as swap_01 is always NA.
+// attribute_hidden void
+static void
+qbeta_raw(double alpha, double p, double q,
+	  Rboolean lower_tail, Rboolean log_p,
 	  int swap_01, // {TRUE, NA, FALSE}: if NA, algorithm decides swap_tail
 	  double log_q_cut, /* if == Inf: return log(qbeta(..));
 			       otherwise, if finite: the bound for
@@ -189,7 +195,8 @@ qbeta_raw(double alpha, double p, double q, int lower_tail, int log_p,
     // Conceptually,  0 < p_ < 1  (but can be 0 or 1 because of cancellation!)
     logbeta = lbeta(p, q);
 
-    swap_tail = (swap_choose) ? (p_ > 0.5) : swap_01;
+    // this is only ever called with swap_choose = TRUE
+    swap_tail = (swap_choose) ? (p_ > 0.5) : (Rboolean) swap_01;
 
     R_ifDEBUG_printf(
 	"qbeta(%g, %g, %g, lower_t=%d, log_p=%d, swap_01=%d, log_q_cut=%g, n_N=%d):%s\n"
@@ -402,7 +409,7 @@ qbeta_raw(double alpha, double p, double q, int lower_tail, int log_p,
 		tx   = 0.;
 		u_n  = ML_NEGINF;
 	    }
-	    use_log_x = log_p; add_N_step = FALSE; goto L_return;
+	    use_log_x = (Rboolean) log_p; add_N_step = FALSE; goto L_return;
 	}
 	else {
 	    R_ifDEBUG_printf(" pbeta(%g, %g, %g, T, log) = %g <= %g (= %s) --> continuing\n",