formally deprecate getMethods() [and more cleanup from r86513]

git-svn-id: https://svn.r-project.org/R/trunk@87282 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: maechler

doc/NEWS.Rd

@@ -149,6 +149,8 @@
       \code{SignatureMethod} were made defunct, as were the
       \code{"MethodsList"} branches of functions \code{assignMethodsMetaData},
       \code{finalDefaultMethod}, and \code{MethodAddCoerce}.
+
+      \item \code{getMethods(*, table=TRUE)} is also deprecated.
     }
   }
 

src/library/methods/R/Methods.R

@@ -1,7 +1,7 @@
 #  File src/library/methods/R/Methods.R
 #  Part of the R package, https://www.R-project.org
 #
-#  Copyright (C) 1995-2023 The R Core Team
+#  Copyright (C) 1995-2024 The R Core Team
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -17,7 +17,7 @@
 #  https://www.R-project.org/Licenses/
 
 ## copy here to avoid importing from stats and hence loading stats
-## namespace when methods if loaded
+## namespace when methods is loaded
 setNames <- stats::setNames
 
 
@@ -351,7 +351,8 @@ getMethods <-
     function(f, where = topenv(parent.frame()), table = FALSE)
 {
     if(!table)
-      .MlistDefunct("getMethods", "findMethods")
+        .MlistDefunct("getMethods", "findMethods")
+    else .Deprecated("getMethodsForDispatch(f, TRUE)")
     nowhere <- missing(where)
     fdef <- getGeneric(f, where = where)
     f <- fdef@generic
@@ -366,41 +367,6 @@ getMethodsForDispatch <- function(fdef, inherited = FALSE)
     .getMethodsTable(fdef, environment(fdef), inherited = inherited)
 }
 
-## Some functions used in MethodsListSelect, that must be safe against recursive
-## method selection.
-
-.setIfBase <- function(f, fdef, mlist) {
-    if(is.null(f))
-        FALSE
-    else {
-        found <- base::exists(f, "package:base")
-	if(found) {
-	    ## force (default) computation of mlist in MethodsListSelect
-	    base::assign(".Methods", envir = base::environment(fdef),
-			 base::get(f, "package:base"))
-	}
-        found
-    }
-}
-
-## Must NOT use the standard version to prevent recursion  {still true ?}
-.getMethodsForDispatch <- function(fdef) {
-    ev <- base::environment(fdef)
-    if(base::exists(".Methods", envir = ev))
-        base::get(".Methods", envir = ev)
-    ## else NULL
-}
-
-.setMethodsForDispatch <- function(f, fdef, mlist) {
-    ev <- environment(fdef)
-    if(!is(fdef, "genericFunction") ||
-       !exists(".Methods", envir = ev, inherits = FALSE))
-        stop(sprintf("internal error: did not get a valid generic function object for function %s",
-                      sQuote(f)),
-             domain = NA)
-    assign(".Methods", envir = ev, mlist)
-}
-
 cacheMethod <-
   ## cache the given definition in the method metadata for f
   ## Support function:  DON'T USE DIRECTLY (does no checking)
@@ -417,6 +383,7 @@ cacheMethod <-
 			      .getMethodsTable(fdef, ev, inherited = TRUE))
   }
 
+## for .removeSubClass() and .removeSuperClass():
 .removeCachedMethod <- function(f, sig, fdef = getGeneric(f))
     cacheMethod(f, sig, NULL, names(sig), fdef)
 

src/library/methods/man/findMethods.Rd

@@ -1,6 +1,6 @@
 % File src/library/methods/man/findMethods.Rd
 % Part of the R package, https://www.R-project.org
-% Copyright 2008-2019 R Core Team
+% Copyright 2008-2024 R Core Team
 % Distributed under GPL 2 or later
 
 \name{findMethods}
@@ -39,7 +39,8 @@
   function \code{f} in the environment or search position \code{where}
   (or for the generic function generally if \code{where} is missing).
 
-  The defunct function \code{getMethods} is an older alternative to
+  The deprecated function \code{getMethods} (defunct for default \code{table=FALSE})
+  is an older alternative to
   \code{findMethods} , returning information in the form of an object of
   class \code{MethodsList}, previously used for method dispatch.  This
   class of objects is deprecated generally and will disappear in a
@@ -54,7 +55,7 @@ findMethodSignatures(..., target = TRUE, methods = )
 hasMethods(f, where, package)
 
 ## Deprecated in 2010 and defunct in 2015 for 'table = FALSE':
-getMethods(f, where, table = FALSE)
+getMethods(f, where, table = FALSE) # deprecated -> use getMethodsForDispatch()
 }
 \arguments{
   \item{f}{A generic function or the character-string name of one.}