tools::checkDocFiles() no longer overlooks nullary functions

smeyer · smeyer · commit fac2194256fa · 2024-10-22T14:36:24.000Z
git-svn-id: https://svn.r-project.org/R/trunk@87263 00db46b3-68df-0310-9c12-caf00c1e9a41
diff --git a/doc/NEWS.Rd b/doc/NEWS.Rd
@@ -273,6 +273,9 @@
       character data.  Set environment variable
       \env{_R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES_}
       to a false value for the previous behaviour.
+
+      \item \code{tools::checkDocFiles()} now also notes \emph{nullary}
+      functions shown in the usage section without corresponding \verb{\alias}.
     }
   }
 
diff --git a/src/library/tools/R/QC.R b/src/library/tools/R/QC.R
@@ -1442,7 +1442,7 @@ function(package, dir, lib.loc = NULL, chkInternal = NULL)
         ## try to deal with data set documentation.
         ind <- vapply(exprs,
                       function(e)
-                          length(e) > 1L && !is_data_for_dataset(e),
+                          is.call(e) && !is_data_for_dataset(e),
                       NA, USE.NAMES=FALSE)
         exprs <- exprs[ind]
         ## Split out replacement function usages.

Original file line number	Diff line number	Diff line change
`@@ -273,6 +273,9 @@`
`273`	`273`	`character data. Set environment variable`
`274`	`274`	`\env{_R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES_}`
`275`	`275`	`to a false value for the previous behaviour.`
	`276`	`+`
	`277`	`+ \item \code{tools::checkDocFiles()} now also notes \emph{nullary}`
	`278`	`+ functions shown in the usage section without corresponding \verb{\alias}.`
`276`	`279`	`}`
`277`	`280`	`}`
`278`	`281`