From 028a0e589b060c3c858cd029aeccff7c0e9ee6a5 Mon Sep 17 00:00:00 2001
From: Michael Chirico <chiricom@google.com>
Date: Thu, 16 Oct 2025 20:33:12 +0000
Subject: [PATCH] Use an empty vector, not "", for methods_message

---
 src/library/tools/R/QC.R | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/library/tools/R/QC.R b/src/library/tools/R/QC.R
index a3c703c53ff..a4f203109ae 100644
--- a/src/library/tools/R/QC.R
+++ b/src/library/tools/R/QC.R
@@ -6202,7 +6202,7 @@ function(package, dir, lib.loc = NULL)
     methods_message <-
         if(uses_methods && "methods" %notin% c(depends, imports))
             gettext("package 'methods' is used but not declared")
-        else ""
+        else character()
 
     extras <- list(
         base = c("Sys.junction", "shell", "shell.exec"),
@@ -6503,7 +6503,7 @@ function(x, ...)
                        sQuote(xx))
           }
       },
-      if(nzchar(x$methods_message)) {
+      if(length(x$methods_message)) {
           x$methods_message
       })
 }
@@ -6621,7 +6621,7 @@ function(db, files)
     res <- list(others = unique(bad_exprs),
                 imports = unique(bad_imports),
                 data = unique(bad_data),
-                methods_message = ""
+                methods_message = character()
               , parse_errors = unique(parse_errors)
             )
     class(res) <- "check_packages_used"