Merge pull request numpy#19934 from WarrenWeckesser/gh19931-memleak

seberg · web-flow · commit 4a60e7099ec6 · 2021-09-23T06:58:00.000-07:00
BUG: core: Fix memory leak in the C function boundarraymethod_repr.
diff --git a/numpy/core/src/multiarray/array_method.c b/numpy/core/src/multiarray/array_method.c
@@ -466,7 +466,6 @@ NPY_NO_EXPORT PyTypeObject PyArrayMethod_Type = {
 };
 
 
-
 static PyObject *
 boundarraymethod_repr(PyBoundArrayMethodObject *self)
 {
@@ -476,9 +475,11 @@ boundarraymethod_repr(PyBoundArrayMethodObject *self)
     if (dtypes == NULL) {
         return NULL;
     }
-    return PyUnicode_FromFormat(
-            "<np._BoundArrayMethod `%s` for dtypes %S>",
-            self->method->name, dtypes);
+    PyObject *repr = PyUnicode_FromFormat(
+                        "<np._BoundArrayMethod `%s` for dtypes %S>",
+                        self->method->name, dtypes);
+    Py_DECREF(dtypes);
+    return repr;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,6 @@ NPY_NO_EXPORT PyTypeObject PyArrayMethod_Type = {`
`466`	`466`	`};`
`467`	`467`
`468`	`468`
`469`		`-`
`470`	`469`	`static PyObject *`
`471`	`470`	`boundarraymethod_repr(PyBoundArrayMethodObject *self)`
`472`	`471`	`{`
`@@ -476,9 +475,11 @@ boundarraymethod_repr(PyBoundArrayMethodObject *self)`
`476`	`475`	`if (dtypes == NULL) {`
`477`	`476`	`return NULL;`
`478`	`477`	`}`
`479`		`- return PyUnicode_FromFormat(`
`480`		- "<np._BoundArrayMethod `%s` for dtypes %S>",
`481`		`- self->method->name, dtypes);`
	`478`	`+ PyObject *repr = PyUnicode_FromFormat(`
	`479`	+ "<np._BoundArrayMethod `%s` for dtypes %S>",
	`480`	`+ self->method->name, dtypes);`
	`481`	`+ Py_DECREF(dtypes);`
	`482`	`+ return repr;`
`482`	`483`	`}`
`483`	`484`
`484`	`485`