Skip to content

Commit a39a546

Browse files
authored
Merge pull request numpy#28102 from rgommers/bump-oldest-gcc
MAINT: update oldest supported GCC version from 8.4 to 9.3
2 parents 8eb0c50 + 13d148d commit a39a546

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

.github/workflows/linux_simd.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,27 +85,27 @@ jobs:
8585
with:
8686
python-version: '3.11'
8787

88-
- name: Install GCC/8/9
88+
- name: Install GCC9/10
8989
run: |
9090
echo "deb http://archive.ubuntu.com/ubuntu focal main universe" | sudo tee /etc/apt/sources.list.d/focal.list
9191
sudo apt update
92-
sudo apt install -y g++-8 g++-9
92+
sudo apt install -y g++-9 g++-10
9393
94-
- name: Enable gcc-8
94+
- name: Enable gcc-9
9595
run: |
96-
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-8 1
97-
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 1
96+
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 1
97+
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-9 1
9898
9999
- uses: ./.github/meson_actions
100-
name: Build/Test against gcc-8
100+
name: Build/Test against gcc-9
101101

102-
- name: Enable gcc-9
102+
- name: Enable gcc-10
103103
run: |
104-
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 2
105-
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-9 2
104+
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 2
105+
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 2
106106
107107
- uses: ./.github/meson_actions
108-
name: Build/Test against gcc-9
108+
name: Build/Test against gcc-10
109109

110110
specialize:
111111
needs: [baseline_only]
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
The minimum supported GCC version is now 9.3.0
2+
----------------------------------------------
3+
The minimum supported version was updated from 8.4.0 to 9.3.0,
4+
primarily in order to reduce the chance of platform-specific bugs in old GCC
5+
versions from causing issues.
6+

meson.build

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ cy = meson.get_compiler('cython')
2424

2525
# Check compiler is recent enough (see the SciPy Toolchain Roadmap for details)
2626
if cc.get_id() == 'gcc'
27-
if not cc.version().version_compare('>=8.4')
28-
error('NumPy requires GCC >= 8.4')
27+
if not cc.version().version_compare('>=9.3')
28+
error('NumPy requires GCC >= 9.3')
2929
endif
3030
elif cc.get_id() == 'msvc'
3131
if not cc.version().version_compare('>=19.20')

0 commit comments

Comments
 (0)