DEP: Deprecate numpy.typing.mypy_plugin: The sequel (numpy#28134)

* DEP: Address mypy plugin deprecation suggestions by @seberg in numpy#28129

* DOC: Release note for the deprecated ``numpy.typing.mypy_plugin``

* Update numpy/typing/mypy_plugin.py

---------

Co-authored-by: Sebastian Berg <[email protected]>

Author: jorenham

doc/release/upcoming_changes/28129.deprecation.rst

@@ -0,0 +1,4 @@
+* The ``numpy.typing.mypy_plugin`` has been deprecated in favor of platform-agnostic
+  static type inference. Please remove ``numpy.typing.mypy_plugin`` from the ``plugins``
+  section of your mypy configuration. If this change results in new errors being
+  reported, kindly open an issue.

numpy/typing/mypy_plugin.py

@@ -16,7 +16,8 @@
   Without the plugin the type will default to `ctypes.c_int64`.
 
   .. versionadded:: 1.22
-  .. deprecated:: 2.3
+
+.. deprecated:: 2.3
 
 Examples
 --------
@@ -32,7 +33,8 @@
 
 """
 
-from typing import Final
+from collections.abc import Callable, Iterable
+from typing import TYPE_CHECKING, Final, TypeAlias, cast
 
 import numpy as np
 
@@ -101,9 +103,6 @@ def _get_c_intp_name() -> str:
 
 
 try:
-    from collections.abc import Callable, Iterable
-    from typing import TYPE_CHECKING, TypeAlias, cast
-
     if TYPE_CHECKING:
         from mypy.typeanal import TypeAnalyser
 
@@ -112,6 +111,13 @@ def _get_c_intp_name() -> str:
     from mypy.nodes import MypyFile, ImportFrom, Statement
     from mypy.build import PRI_MED
 
+except ModuleNotFoundError as e:
+
+    def plugin(version: str) -> type:
+        raise e
+
+else:
+
     _HookFunc: TypeAlias = Callable[[AnalyzeTypeContext], mypy.types.Type]
 
     def _hook(ctx: AnalyzeTypeContext) -> mypy.types.Type:
@@ -186,15 +192,13 @@ def get_additional_deps(
     def plugin(version: str) -> type:
         import warnings
 
-        warnings.warn(
-            "`numpy.typing.mypy_plugin` is deprecated, and will be removed in "
-            "a future release.",
-            category=DeprecationWarning,
-            stacklevel=3,
+        plugin = "numpy.typing.mypy_plugin"
+        # Deprecated 2025-01-10, NumPy 2.3
+        warn_msg = (
+            f"`{plugin}` is deprecated, and will be removed in a future "
+            f"release. Please remove `plugins = {plugin}` in your mypy config."
+            f"(deprecated in NumPy 2.3)"
         )
-        return _NumpyPlugin
-
-except ModuleNotFoundError as e:
+        warnings.warn(warn_msg, DeprecationWarning, stacklevel=3)
 
-    def plugin(version: str) -> type:
-        raise e
+        return _NumpyPlugin