Deprecate check_rhub()

Author: jennybc

NEWS.md

@@ -8,7 +8,7 @@
 * `test_coverage_active_file()` now reports if any tests failed and does
   a better job of executing snapshot comparisons.
 
-* `dev_mode()` is deprecated.
+* `dev_mode()` and `check_rhub()` are deprecated.
 
 # devtools 2.4.5
 
@@ -528,7 +528,7 @@ you should switch your package to depend on **usethis** directly instead.
 * `document()`, `load_all()`, `check()`, `build()` and `test()` now
   automatically save open files when they are run inside the RStudio IDE. (#1576)
 
-* New `check_rhub()` function to check packages using <https://builder.r-hub.io/>.
+* New `check_rhub()` function to check packages using `https://builder.r-hub.io/`.
 
 * `run_examples` was mistakenly passing `show` to
   `pkgload::run_example`, causing it to fail (@amcdavid, #1449)

R/r-hub.R

@@ -1,62 +1,28 @@
-
 #' Run CRAN checks for package on R-hub
 #'
-#' It runs [build()] on the package, with the arguments specified
-#' in `args`, and then submits it to the R-hub builder at
-#' <https://builder.r-hub.io>. The `interactive` option controls
-#' whether the function waits for the check output. Regardless, after the
-#' check is complete, R-hub sends an email with the results to the package
-#' maintainer.
+#' @description
+#' `r lifecycle::badge("deprecated")`
 #'
-#' @section About email validation on r-hub:
-#' To build and check R packages on R-hub, you need to validate your
-#' email address. This is because R-hub sends out emails about build
-#' results. See more at [rhub::validate_email()].
+#' This function is deprecated since the underlying function
+#' `rhub::check_for_cran()` is now deprecated and defunct. See [`rhub::rhubv2`]
+#' learn about the new check system, R-hub v2.
 #'
-#' @param platforms R-hub platforms to run the check on. If `NULL`
-#'   uses default list of CRAN checkers (one for each major platform, and
-#'   one with extra checks if you have compiled code). You can also specify
-#'   your own, see [rhub::platforms()] for a complete list.
-#' @param email email address to notify, defaults to the maintainer
-#'   address in the package.
-#' @param interactive whether to show the status of the build
-#'   interactively. R-hub will send an email to the package maintainer's
-#'   email address, regardless of whether the check is interactive or not.
-#' @param build_args Arguments passed to `R CMD build`
-#' @param ... extra arguments, passed to [rhub::check_for_cran()].
+#' @param platforms R-hub platforms to run the check on.
+#' @param email email address to notify.
+#' @param interactive whether to show the status of the build.
+#' @param build_args Arguments passed to `R CMD build`.
+#' @param ... extra arguments, passed to `rhub::check_for_cran()`.
 #' @inheritParams check
-#' @family build functions
 #' @return a `rhub_check` object.
-#'
+#' @keywords internal
 #' @export
-
-check_rhub <- function(pkg = ".",
-                       platforms = NULL,
-                       email = NULL,
-                       interactive = TRUE,
-                       build_args = NULL,
-                       ...) {
-  rlang::check_installed("rhub")
-  pkg <- as.package(pkg)
-
-  built_path <- build(pkg$path, tempdir(), quiet = !interactive,
-                      args = build_args)
-  on.exit(file_delete(built_path), add = TRUE)
-
-  check_dots_used(action = getOption("devtools.ellipsis_action", rlang::warn))
-
-  status <- rhub::check_for_cran(
-    path = built_path,
-    email = email,
-    platforms = platforms,
-    show_status = interactive,
-    ...
-  )
-
-  if (!interactive) {
-    cli::cli_inform(c(v = "R-hub check for package {.pkg {pkg$package}} submitted."))
-    status
-  } else {
-    status
-  }
+check_rhub <- function(
+  pkg = ".",
+  platforms = NULL,
+  email = NULL,
+  interactive = TRUE,
+  build_args = NULL,
+  ...
+) {
+  lifecycle::deprecate_stop("2.4.6", "check_rhub()")
 }

R/release.R

@@ -83,7 +83,7 @@ release <- function(pkg = ".", check = FALSE, args = NULL) {
     }
   }
 
-  if (yesno("Have you checked on R-hub (with `check_rhub()`)?")) {
+  if (yesno("Have you checked on R-hub (see `?rhub::rhubv2`)?")) {
     return(invisible())
   }
 

README.md

@@ -74,13 +74,11 @@ look in the current working directory - this is a recommended practice.
 ### Check and release:
 
 * `check()` updates the documentation, then builds and checks the package locally.
-  `check_win()` checks a package using
-  [win-builder](https://win-builder.r-project.org/), and `check_rhub()` checks a package using
-  [r-hub](https://log.r-hub.io/). This allows you to easily check
-  your package on all systems CRAN uses before submission.
-
-* `release()` makes sure everything is ok with your package (including asking
-  you a number of questions), then builds and uploads to CRAN.
+* `check_win_release()`, `check_win_devel()`, and `check_mac_release()` check
+  a package using [win-builder](https://win-builder.r-project.org/) or
+  <https://mac.r-project.org/macbuilder/submit.html>.
+* `release()` and `submit_cran()` handle the mechanics of CRAN submission with
+  or without, respectively, (re)-running lots of local checks.
 
 ## Learning more