create_response() already sets the last response (#736)

hadley · web-flow · commit 2f20100c18c0 · 2025-06-13T08:45:50.000-05:00
diff --git a/R/req-perform-connection.R b/R/req-perform-connection.R
@@ -140,9 +140,7 @@ req_perform_connection1 <- function(req, handle, blocking = TRUE) {
   }
 
   curl_data <- curl::handle_data(handle)
-
-  the$last_response <- create_response(req, curl_data, body)
-  the$last_response
+  create_response(req, curl_data, body)
 }
 
 # Make open mockable
diff --git a/R/req-perform.R b/R/req-perform.R
@@ -190,8 +190,7 @@ req_perform1 <- function(req, path = NULL, handle = NULL) {
   curl::handle_setopt(handle, cookielist = "FLUSH")
   curl::handle_setopt(handle, cookiefile = NULL, cookiejar = NULL)
 
-  the$last_response <- create_response(req, fetch$curl_data, fetch$body)
-  the$last_response
+  create_response(req, fetch$curl_data, fetch$body)
 }
 
 curl_fetch <- function(handle, url, path) {

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,7 @@ req_perform_connection1 <- function(req, handle, blocking = TRUE) {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`curl_data <- curl::handle_data(handle)`
`143`		`-`
`144`		`- the$last_response <- create_response(req, curl_data, body)`
`145`		`- the$last_response`
	`143`	`+ create_response(req, curl_data, body)`
`146`	`144`	`}`
`147`	`145`
`148`	`146`	`# Make open mockable`
Original file line number	Diff line number	Diff line change
`@@ -190,8 +190,7 @@ req_perform1 <- function(req, path = NULL, handle = NULL) {`
`190`	`190`	`curl::handle_setopt(handle, cookielist = "FLUSH")`
`191`	`191`	`curl::handle_setopt(handle, cookiefile = NULL, cookiejar = NULL)`
`192`	`192`
`193`		`- the$last_response <- create_response(req, fetch$curl_data, fetch$body)`
`194`		`- the$last_response`
	`193`	`+ create_response(req, fetch$curl_data, fetch$body)`
`195`	`194`	`}`
`196`	`195`
`197`	`196`	`curl_fetch <- function(handle, url, path) {`