Skip to content

Commit 8db7193

Browse files
authored
Document resps_data() + resp_body_raw() edge case (#630)
Fixes #621
1 parent dbd27a5 commit 8db7193

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

R/iterate-responses.R

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
#' @param resps A list of responses (possibly including errors).
1717
#' @param resp_data A function that takes a response (`resp`) and
1818
#' returns the data found inside that response as a vector or data frame.
19+
#'
20+
#' NB: If you're using [resp_body_raw()], you're likely to want to wrap its
21+
#' output in `list()` to avoid combining all the bodies into a single raw
22+
#' vector, e.g. `resps |> resps_data(\(resp) list(resp_body_raw(resp)))`.
23+
#'
1924
#' @examples
2025
#' reqs <- list(
2126
#' request(example_url()) |> req_url_path("/ip"),
@@ -29,10 +34,14 @@
2934
#' resps |> resps_successes()
3035
#'
3136
#' # collect all their data
32-
#' resps |> resps_successes() |> resps_data(\(resp) resp_body_json(resp))
37+
#' resps |>
38+
#' resps_successes() |>
39+
#' resps_data(\(resp) resp_body_json(resp))
3340
#'
3441
#' # find requests corresponding to failure responses
35-
#' resps |> resps_failures() |> resps_requests()
42+
#' resps |>
43+
#' resps_failures() |>
44+
#' resps_requests()
3645
resps_successes <- function(resps) {
3746
resps[resps_ok(resps)]
3847
}

man/resps_successes.Rd

Lines changed: 11 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)