Skip to content

Commit 959a8cb

Browse files
committed
Eliminate message about default argument in tests
1 parent ce6b530 commit 959a8cb

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

tests/testthat/test-req-retries.R

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test_that("can override default is_transient", {
2828
expect_equal(retry_is_transient(req, response(404)), FALSE)
2929
expect_equal(retry_is_transient(req, response(429)), TRUE)
3030

31-
req <- req_retry(req, is_transient = ~ resp_status(.x) == 404)
31+
req <- req_retry(req, max_tries = 2, is_transient = ~ resp_status(.x) == 404)
3232
expect_equal(retry_is_transient(req, response(404)), TRUE)
3333
expect_equal(retry_is_transient(req, response(429)), FALSE)
3434
})
@@ -41,7 +41,7 @@ test_that("can override default backoff", {
4141
expect_equal(retry_backoff(req, 5), 26.9)
4242
expect_equal(retry_backoff(req, 10), 60)
4343

44-
req <- req_retry(req, backoff = ~10)
44+
req <- req_retry(req, max_tries = 2, backoff = ~10)
4545
expect_equal(retry_backoff(req, 1), 10)
4646
expect_equal(retry_backoff(req, 5), 10)
4747
expect_equal(retry_backoff(req, 10), 10)
@@ -52,13 +52,17 @@ test_that("can override default retry wait", {
5252
req <- request_test()
5353
expect_equal(retry_after(req, resp, 1), 10)
5454

55-
req <- req_retry(req, after = ~ as.numeric(resp_header(.x, "Wait-For")))
55+
req <- req_retry(
56+
req,
57+
max_tries = 2,
58+
after = ~ as.numeric(resp_header(.x, "Wait-For"))
59+
)
5660
expect_equal(retry_after(req, resp, 1), 20)
5761
})
5862

5963
test_that("missing retry-after uses backoff", {
6064
req <- request_test()
61-
req <- req_retry(req, backoff = ~10)
65+
req <- req_retry(req, max_tries = 2, backoff = ~10)
6266

6367
expect_equal(retry_after(req, response(429), 1), 10)
6468
})
@@ -67,7 +71,8 @@ test_that("useful message if `after` wrong", {
6771
req <- request_test() %>%
6872
req_retry(
6973
is_transient = function(resp) TRUE,
70-
after = function(resp) resp
74+
after = function(resp) resp,
75+
max_tries = 2
7176
)
7277

7378
expect_snapshot(req_perform(req), error = TRUE)
@@ -117,7 +122,7 @@ test_that("triggered after specified requests", {
117122

118123
# Attempt on same realm errors without trying at all
119124
req2 <- request_test("/status/:status", status = 200) %>%
120-
req_retry()
125+
req_retry(max_tries = 2)
121126
req_perform(req) %>%
122127
expect_no_condition(class = "httr2_perform") %>%
123128
expect_error(class = "httr2_breaker")

0 commit comments

Comments
 (0)