Skip to content

Commit b1bb9f3

Browse files
authored
Make parallel unit test more robust (#623)
1 parent e6f425e commit b1bb9f3

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

R/test.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ example_url <- function() {
5050
env_cache(the, "test_app",
5151
webfakes::new_app_process(
5252
app,
53-
opts = webfakes::server_opts(num_threads = 2)
53+
opts = webfakes::server_opts(num_threads = 6, enable_keep_alive = TRUE)
5454
)
5555
)
5656
the$test_app$url()

tests/testthat/test-multi-req.R

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,9 @@ test_that("correctly prepares request", {
99
})
1010

1111
test_that("requests happen in parallel", {
12-
# GHA MacOS builder seems to be very slow
13-
skip_if(
14-
isTRUE(as.logical(Sys.getenv("CI", "false"))) &&
15-
Sys.info()[["sysname"]] == "Darwin"
16-
)
17-
12+
# test works best if webfakes has ample threads and keepalive
1813
reqs <- list2(
14+
request_test("/delay/:secs", secs = 0),
1915
request_test("/delay/:secs", secs = 0.25),
2016
request_test("/delay/:secs", secs = 0.25),
2117
request_test("/delay/:secs", secs = 0.25),

0 commit comments

Comments
 (0)