Update roxygen2 to 7.3.3 (#2930)

* Use base:: qualification to avoid linking backports in roxygen2

* continuing...

* stopifnot

* stopifnot, again

* try a regex approach

* use roxygen2 7.3.3

* remove TODO

Author: MichaelChirico

DESCRIPTION

@@ -59,7 +59,7 @@ Config/Needs/development: pkgload, testthat, patrick
 Config/testthat/edition: 3
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.2
+RoxygenNote: 7.3.3
 Collate:
     'make_linter_from_xpath.R'
     'xp_utils.R'

R/any_is_na_linter.R

@@ -1,6 +1,6 @@
 #' Require usage of `anyNA(x)` over `any(is.na(x))`
 #'
-#' [anyNA()] exists as a replacement for `any(is.na(x))` which is more efficient
+#' [base::anyNA()] exists as a replacement for `any(is.na(x))` which is more efficient
 #'   for simple objects, and is at worst equally efficient.
 #'   Therefore, it should be used in all situations instead of the latter.
 #'

R/condition_message_linter.R

@@ -2,7 +2,7 @@
 #'
 #' @description
 #' This linter discourages combining condition functions like [stop()] with string concatenation
-#'   functions [paste()] and [paste0()]. This is because
+#'   functions [base::paste()] and [base::paste0()]. This is because
 #'
 #'  - `stop(paste0(...))` is redundant as it is exactly equivalent to `stop(...)`
 #'  - `stop(paste(...))` is similarly equivalent to `stop(...)` with separators (see examples)

R/conjunct_test_linter.R

@@ -5,7 +5,7 @@
 #'   `expect_true(A); expect_true(B)` is better than `expect_true(A && B)`, and
 #'   `expect_false(A); expect_false(B)` is better than `expect_false(A || B)`.
 #'
-#' Similar reasoning applies to `&&` usage inside [stopifnot()] and `assertthat::assert_that()` calls.
+#' Similar reasoning applies to `&&` usage inside [base::stopifnot()] and `assertthat::assert_that()` calls.
 #'
 #' Relatedly, `dplyr::filter(DF, A & B)` is the same as `dplyr::filter(DF, A, B)`, but the latter will be more readable
 #'   / easier to format for long conditions. Note that this linter assumes usages of `filter()` are `dplyr::filter()`;

R/consecutive_assertion_linter.R

@@ -1,6 +1,6 @@
 #' Force consecutive calls to assertions into just one when possible
 #'
-#' [stopifnot()] accepts any number of tests, so sequences like
+#' [base::stopifnot()] accepts any number of tests, so sequences like
 #'   `stopifnot(x); stopifnot(y)` are redundant. Ditto for tests using
 #'   `assertthat::assert_that()` without specifying `msg=`.
 #'

R/get_source_expressions.R

@@ -274,7 +274,7 @@ lint_parse_error_r43 <- function(e, source_expression) {
 
 #' Convert a R < 4.3.0 standard parse error message into a lint
 #'
-#' @param message_info Match of the structured parse error message regex, matched in [lint_parse_error()]
+#' @param message_info Match of the structured parse error message regex, matched in `lint_parse_error()`
 #' @param source_expression The source expression that generated the parse error
 #'
 #' @return A [Lint()] based on text mining of the error message captured by `message_info`,

R/implicit_assignment_linter.R

@@ -1,7 +1,7 @@
 #' Avoid implicit assignment in function calls
 #'
 #' Assigning inside function calls makes the code difficult to read, and should
-#' be avoided, except for functions that capture side-effects (e.g. [capture.output()]).
+#' be avoided, except for functions that capture side-effects (e.g. [utils::capture.output()]).
 #'
 #' @param except A character vector of functions to be excluded from linting.
 #' @param allow_lazy logical, default `FALSE`. If `TRUE`, assignments that only

R/lengths_linter.R

@@ -1,6 +1,6 @@
 #' Require usage of `lengths()` where possible
 #'
-#' [lengths()] is a function that was added to base R in version 3.2.0 to
+#' [base::lengths()] is a function that was added to base R in version 3.2.0 to
 #'   get the length of each element of a list. It is equivalent to
 #'   `sapply(x, length)`, but faster and more readable.
 #'

R/list2df_linter.R

@@ -1,6 +1,6 @@
 #' Recommend direct usage of `data.frame()` to create a data.frame from a list
 #'
-#' [list2DF()] is the preferred way to turn a list of columns into a data.frame.
+#' [base::list2DF()] is the preferred way to turn a list of columns into a data.frame.
 #'   Note that it doesn't support recycling; if that's required, use [data.frame()].
 #'
 #' @examples

R/paste_linter.R

@@ -5,13 +5,13 @@
 #' The following issues are linted by default by this linter
 #'   (see arguments for which can be de-activated optionally):
 #'
-#'  1. Block usage of [paste()] with `sep = ""`. [paste0()] is a faster, more concise alternative.
+#'  1. Block usage of [base::paste()] with `sep = ""`. [base::paste0()] is a faster, more concise alternative.
 #'  2. Block usage of `paste()` or `paste0()` with `collapse = ", "`. [toString()] is a direct
 #'     wrapper for this, and alternatives like [glue::glue_collapse()] might give better messages for humans.
 #'  3. Block usage of `paste0()` that supplies `sep=` -- this is not a formal argument to `paste0`, and
 #'     is likely to be a mistake.
 #'  4. Block usage of `paste()` / `paste0()` combined with [rep()] that could be replaced by
-#'     [strrep()]. `strrep()` can handle the task of building a block of repeated strings
+#'     [base::strrep()]. `strrep()` can handle the task of building a block of repeated strings
 #'     (e.g. often used to build "horizontal lines" for messages). This is both more readable and
 #'     skips the (likely small) overhead of putting two strings into the global string cache when only one is needed.
 #'