Use expectations to check for absence of exceptions (#1880)

IndrajeetPatil · web-flow · commit 4f12a43d5259 · 2023-03-17T21:20:56.000+01:00
Related to #1874
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -44,7 +44,7 @@ Suggests:
     rlang,
     rmarkdown,
     rstudioapi (>= 0.2),
-    testthat (>= 3.0.0),
+    testthat (>= 3.1.5),
     tibble,
     tufte,
     withr (>= 2.5.0)
diff --git a/tests/testthat/test-get_source_expressions.R b/tests/testthat/test-get_source_expressions.R
@@ -344,7 +344,7 @@ patrick::with_parameters_test_that(
   {
     linter <- eval(call(linter))
     expression <- expressions[[expression_idx]]
-    expect_warning(lints <- linter(expression), NA)
+    expect_no_warning(lints <- linter(expression))
     expect_length(lints, 0L)
   },
   .test_name = param_df$.test_name,

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ patrick::with_parameters_test_that(`
`344`	`344`	`{`
`345`	`345`	`linter <- eval(call(linter))`
`346`	`346`	`expression <- expressions[[expression_idx]]`
`347`		`- expect_warning(lints <- linter(expression), NA)`
	`347`	`+ expect_no_warning(lints <- linter(expression))`
`348`	`348`	`expect_length(lints, 0L)`
`349`	`349`	`},`
`350`	`350`	`.test_name = param_df$.test_name,`