Retire Github comment bot settings and tests (#2537)

* Retire Github comment bot settings and tests

Follow-up on https://github.com/r-lib/lintr/pull/1902/files

More discussion in #1558

* piggyback on the existing NEWS item

Author: IndrajeetPatil

NEWS.md

@@ -14,7 +14,7 @@
 * Adjusted various lint messages for consistency in readability (#1330, @MichaelChirico). In general, we favor lint messages to be phrased like "Action, reason" to but the "what" piece of the message front-and-center. This may be a breaking change for code that tests the specific phrasing of lints.
 * `extraction_operator_linter()` is deprecated. Although switching from `$` to `[[` has some robustness benefits for package code, it can lead to non-idiomatic code in many contexts (e.g. R6 classes, Shiny applications, etc.) (#2409, @IndrajeetPatil). To enable the detection of the `$` operator for extraction through partial matching, use `options(warnPartialMatchDollar = TRUE)`.
 * `unnecessary_nested_if_linter()` is deprecated and subsumed into the new/more general `unnecessary_nesting_linter()`.
-* Drop support for posting GitHub comments from inside Travis, Wercker, and Jenkins CI tools (spurred by #2148, @MichaelChirico). We rely on GitHub Actions for linting in CI, and don't see any active users relying on these alternatives. We welcome and encourage community contributions to get support for different CI system going again.
+* Drop support for posting GitHub comments from inside GitHub comment bot, Travis, Wercker, and Jenkins CI tools (spurred by #2148, @MichaelChirico). We rely on GitHub Actions for linting in CI, and don't see any active users relying on these alternatives. We welcome and encourage community contributions to get support for different CI system going again.
 
 ## Bug fixes
 

R/zzz.R

@@ -257,7 +257,6 @@ rd_undesirable_operators <- function() {
 #'  - `exclusions`: a list of exclusions, see [exclude()] for a complete description of valid values.
 #'  - `cache_directory`: location of cache directory
 #'  - `comment_token`: a GitHub token character
-#'  - `comment_bot`: decides if lintr comment bot on GitHub can comment on commits
 #'  - `error_on_lint`: decides if error should be produced when any lints are found
 #'
 #' There are no settings without defaults, i.e., this list describes every valid setting.
@@ -328,7 +327,6 @@ settings <- new.env(parent = emptyenv())
       ),
       54L - 13L
     ),
-    comment_bot = logical_env("LINTR_COMMENT_BOT") %||% TRUE,
     error_on_lint = logical_env("LINTR_ERROR_ON_LINT") %||% FALSE
   ))
 

man/default_settings.Rd

@@ -188,15 +188,6 @@ test_that("validate_config_file() detects improperly-formed settings", {
   writeLines('exclude: "("', .lintr)
   expect_error(lint_dir(), "Setting 'exclude' should be a single regular expression, not '('", fixed = TRUE)
 
-  writeLines('comment_bot: "a"', .lintr)
-  expect_error(lint_dir(), "Setting 'comment_bot' should be TRUE or FALSE, not 'a'", fixed = TRUE)
-
-  writeLines("comment_bot: NA", .lintr)
-  expect_error(lint_dir(), "Setting 'comment_bot' should be TRUE or FALSE, not 'NA'", fixed = TRUE)
-
-  writeLines("comment_bot: c(TRUE, FALSE)", .lintr)
-  expect_error(lint_dir(), "Setting 'comment_bot' should be TRUE or FALSE, not 'TRUE, FALSE'", fixed = TRUE)
-
   writeLines("linters: list(1)", .lintr)
   expect_error(lint_dir(), "Setting 'linters' should be a list of linters", fixed = TRUE)