Support cases of stop(sprintf( in condition_call_linter (#2890)

Author: Bisaloo

NEWS.md

@@ -18,6 +18,7 @@
 * `Lint()`, and thus all linters, ensures that the returned object's `message` attribute is consistently a simple character string (and not, for example, an object of class `"glue"`; #2740, @MichaelChirico).
 * Files with encoding inferred from settings read more robustly under `lint(parse_settings = TRUE)` (#2803, @MichaelChirico).
 * `assignment_linter()` no longer errors if `"%<>%"` is an allowed operator (#2850, @AshesITR).
+* `condition_call_linter()` no longer covers cases where the object type in the ellipsis cannot be determined with certainty (#2888, #2890, @Bisaloo). In particular, this fixes the known false positive of custom conditions created via `errorCondition()` or `warningCondition()` not being compatible with the `call.` argument in `stop()` or `warning()`.
 
 ## Changes to default linters
 

R/condition_call_linter.R

@@ -56,16 +56,23 @@
 #'   - <https://design.tidyverse.org/err-call.html>>
 #' @export
 condition_call_linter <- function(display_call = FALSE) {
+
+  str_fct <- c("sprintf", "gettextf", "paste", "paste0", "format", "tr_")
+  str_literal_or_fct <- glue::glue("
+    STR_CONST
+    or expr/SYMBOL_FUNCTION_CALL[ { xp_text_in_table(str_fct) }]
+  ")
+
   call_xpath <- glue::glue("
-    following-sibling::expr/STR_CONST
+    following-sibling::expr[ {str_literal_or_fct} ]
     and following-sibling::SYMBOL_SUB[text() = 'call.']
       /following-sibling::expr[1]
       /NUM_CONST[text() = '{!display_call}']
   ")
-  no_call_xpath <- "
-    following-sibling::expr/STR_CONST
+  no_call_xpath <- glue::glue("
+    following-sibling::expr[ {str_literal_or_fct} ]
     and parent::expr[not(SYMBOL_SUB[text() = 'call.'])]
-  "
+  ")
 
   if (is.na(display_call)) {
     call_cond <- no_call_xpath

tests/testthat/test-condition_call_linter.R

@@ -28,6 +28,8 @@ patrick::with_parameters_test_that(
 
     expect_lint(paste0(call_name, "('test')"), lint_message, linter)
     expect_lint(paste0(call_name, "('test', call. = TRUE)"), lint_message, linter)
+    expect_lint(paste0(call_name, "(sprintf('test'))"), lint_message, linter)
+    expect_lint(paste0(call_name, "(gettextf('test'))"), lint_message, linter)
 
     linter <- condition_call_linter(display_call = TRUE)
     lint_message <- rex::rex(call_name, anything, "to display the call")