Skip to content

Commit 37ad960

Browse files
committed
Add news item and test
1 parent ea6e89e commit 37ad960

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#### New Features
1010

11+
* Adds `workbench_config()` to launch remote daemons using the default-configured Kubernetes or traditional cluster on Posit Workbench.
1112
* Adds `with_daemons()` and `local_daemons()` helper functions for using a particular compute profile.
1213
This works with daemons that are already set up unlike the existing `with.miraiDaemons()` method, which creates a new scope and tears it down when finished (#360).
1314
* A mirai now has an attribute `id`, which is a monotonically increasing integer identifier unique to each session.

R/launchers.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ cluster_config <- function(command = "sbatch", options = "", rscript = "Rscript"
412412
#' Workbench Remote Launch Configuration
413413
#'
414414
#' Generates a remote configuration for launching daemons using the default
415-
#' launcher configured in Posit Workbench.
415+
#' configured Kubernetes or traditional cluster in Posit Workbench.
416416
#'
417417
#' @inherit remote_config return
418418
#'
@@ -424,7 +424,7 @@ cluster_config <- function(command = "sbatch", options = "", rscript = "Rscript"
424424
#'
425425
#' \dontrun{
426426
#'
427-
#' # Launch 2 daemons using the Workbench default launcher:
427+
#' # Launch 2 daemons using the Workbench default:
428428
#' daemons(n = 2, url = host_url(), remote = workbench_config())
429429
#' }
430430
#'

R/mirai-package.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@
8181
not_found = "compute profile `%s` not found",
8282
numeric_n = "`n` must be numeric, did you mean to provide `url`?",
8383
rstudio_api = "workbench launcher requires the `rstudioapi` package",
84-
rstudio_unavailable = "workbench launcher requires a compatible environment",
8584
sync_daemons = "mirai: initial sync with daemon(s) [%d secs elapsed]",
8685
sync_dispatcher = "mirai: initial sync with dispatcher [%d secs elapsed]",
8786
within_map = "cannot create local daemons from within mirai map"

tests/tests.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ test_true(grepl("5555", local_url(tcp = TRUE, port = 5555), fixed = TRUE))
4343
test_type("list", ssh_config("ssh://remotehost"))
4444
test_type("list", ssh_config("ssh://remotehost", tunnel = TRUE))
4545
test_type("list", cluster_config())
46+
test_type("list", tryCatch(workbench_config(), error = function(cnd) list()))
4647
test_true(is_mirai_interrupt(r <- mirai:::mk_interrupt_error()))
4748
test_print(r)
4849
test_true(is_mirai_error(r <- `class<-`("Error in: testing\n", c("miraiError", "errorValue", "try-error"))))

0 commit comments

Comments
 (0)