Skip to content

Commit 62356ea

Browse files
committed
Add news item and test
1 parent a86aef4 commit 62356ea

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# mirai (development version)
22

3+
#### New Features
4+
5+
* Adds `workbench_config()` to launch remote daemons using the default-configured Kubernetes or traditional cluster on Posit Workbench.
6+
37
# mirai 2.4.1
48

59
#### New Features

R/launchers.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ cluster_config <- function(
451451
#' Workbench Remote Launch Configuration
452452
#'
453453
#' Generates a remote configuration for launching daemons using the default
454-
#' launcher configured in Posit Workbench.
454+
#' configured Kubernetes or traditional cluster in Posit Workbench.
455455
#'
456456
#' @inherit remote_config return
457457
#'
@@ -463,7 +463,7 @@ cluster_config <- function(
463463
#'
464464
#' \dontrun{
465465
#'
466-
#' # Launch 2 daemons using the Workbench default launcher:
466+
#' # Launch 2 daemons using the Workbench default:
467467
#' daemons(n = 2, url = host_url(), remote = workbench_config())
468468
#' }
469469
#'

R/mirai-package.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@
8484
not_found = "compute profile `%s` not found",
8585
numeric_n = "`n` must be numeric, did you mean to provide `url`?",
8686
rstudio_api = "workbench launcher requires the `rstudioapi` package",
87-
rstudio_unavailable = "workbench launcher requires a compatible environment",
8887
sync_daemons = "mirai: initial sync with daemon(s) [%d secs elapsed]",
8988
sync_dispatcher = "mirai: initial sync with dispatcher [%d secs elapsed]",
9089
within_map = "cannot create local daemons from within mirai map"

tests/tests.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ test_true(grepl("5555", local_url(tcp = TRUE, port = 5555), fixed = TRUE))
4242
test_type("list", ssh_config("ssh://remotehost"))
4343
test_type("list", ssh_config("ssh://remotehost", tunnel = TRUE))
4444
test_type("list", cluster_config())
45+
test_type("list", tryCatch(workbench_config(), error = function(cnd) list()))
4546
test_true(is_mirai_interrupt(r <- mirai:::mk_interrupt_error()))
4647
test_print(r)
4748
test_true(is_mirai_error(r <- `class<-`("Error in: testing\n", c("miraiError", "errorValue", "try-error"))))

0 commit comments

Comments
 (0)