Skip to content

Commit 960c8dc

Browse files
authored
Safer naming of internal mirai elements (#405)
1 parent 70930fa commit 960c8dc

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

R/daemon.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ eval_mirai <- function(._mirai_.) {
202202
withRestarts(
203203
withCallingHandlers(
204204
{
205-
list2env(._mirai_.[["._mirai_globals_."]], envir = .GlobalEnv)
206-
eval(._mirai_.[[".expr"]], envir = ._mirai_., enclos = .GlobalEnv)
205+
list2env(._mirai_.[["._globals_."]], envir = .GlobalEnv)
206+
eval(._mirai_.[["._expr_."]], envir = ._mirai_., enclos = .GlobalEnv)
207207
},
208208
error = handle_mirai_error,
209209
interrupt = handle_mirai_interrupt

R/mirai.R

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,12 @@ mirai <- function(.expr, ..., .args = list(), .timeout = NULL, .compute = NULL)
157157
globals[[".Random.seed"]] <- next_stream(envir)
158158
}
159159
data <- list(
160-
._mirai_globals_. = globals,
161-
.expr = if (
160+
._expr_. = if (
162161
is.symbol(expr) &&
163162
exists(as.character(expr), envir = parent.frame()) &&
164163
is.language(.expr)
165-
) .expr else expr
164+
) .expr else expr,
165+
._globals_. = globals
166166
)
167167
if (length(.args)) {
168168
if (is.environment(.args)) {
@@ -614,14 +614,14 @@ mk_mirai_error <- function(cnd, sc) {
614614
cnd[["call"]] <- `attributes<-`(.subset2(cnd, "call"), NULL)
615615
call <- deparse_safe(.subset2(cnd, "call"))
616616
msg <- if (
617-
is.null(call) || call == "eval(._mirai_.[[\".expr\"]], envir = ._mirai_., enclos = .GlobalEnv)"
617+
is.null(call) || call == "eval(._mirai_.[[\"._expr_.\"]], envir = ._mirai_., enclos = .GlobalEnv)"
618618
) {
619619
sprintf("Error: %s", .subset2(cnd, "message"))
620620
} else {
621621
sprintf("Error in %s: %s", call, .subset2(cnd, "message"))
622622
}
623623
idx <- max(which(as.logical(lapply(
624-
sc, `==`, "eval(._mirai_.[[\".expr\"]], envir = ._mirai_., enclos = .GlobalEnv)"
624+
sc, `==`, "eval(._mirai_.[[\"._expr_.\"]], envir = ._mirai_., enclos = .GlobalEnv)"
625625
))))
626626
sc <- sc[(length(sc) - 1L):(idx + 1L)]
627627
if (sc[[1L]][[1L]] == ".handleSimpleError") sc <- sc[-1L]

0 commit comments

Comments
 (0)