automatic detection for latomic linker flag

Author: shikokuchuo

README.Rmd

@@ -478,11 +478,6 @@ Otherwise, the environment variable `Sys.setenv(NANONEXT_TLS=1)` may be set prio
 - your system installations of 'libnng' (built with TLS support) and 'libmbedtls' are in different locations; or
 - you have a system installation of 'libmbedtls' but not 'libnng' and want nanonext to download and build a more recent version of 'libnng' than available in system repositories against this.
 
-#### Certain ARM architectures
-
-If package installation initially fails with an error message of `unable to load shared object:[ ] undefined symbol: __atomic_fetch_sub_8` or similar, please set the environment variable
-`Sys.setenv(NANONEXT_ARM=1)` and then proceed with installation again.
-
 ### Links
 
 nanonext on CRAN: <https://cran.r-project.org/package=nanonext><br />

README.md

@@ -105,7 +105,7 @@ Send message from ‘nano1’:
 
 ``` r
 nano1$send("hello world!")
-#>  [1] 58 0a 00 00 00 03 00 04 01 03 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
+#>  [1] 58 0a 00 00 00 03 00 04 02 00 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
 #> [26] 00 10 00 00 00 01 00 04 00 09 00 00 00 0c 68 65 6c 6c 6f 20 77 6f 72 6c 64
 #> [51] 21
 ```
@@ -115,7 +115,7 @@ Receive message using ‘nano2’:
 ``` r
 nano2$recv()
 #> $raw
-#>  [1] 58 0a 00 00 00 03 00 04 01 03 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
+#>  [1] 58 0a 00 00 00 03 00 04 02 00 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
 #> [26] 00 10 00 00 00 01 00 04 00 09 00 00 00 0c 68 65 6c 6c 6f 20 77 6f 72 6c 64
 #> [51] 21
 #> 
@@ -146,7 +146,7 @@ Send message from ‘socket1’:
 
 ``` r
 send(socket1, "hello world!")
-#>  [1] 58 0a 00 00 00 03 00 04 01 03 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
+#>  [1] 58 0a 00 00 00 03 00 04 02 00 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
 #> [26] 00 10 00 00 00 01 00 04 00 09 00 00 00 0c 68 65 6c 6c 6f 20 77 6f 72 6c 64
 #> [51] 21
 ```
@@ -156,7 +156,7 @@ Receive message using ‘socket2’:
 ``` r
 recv(socket2)
 #> $raw
-#>  [1] 58 0a 00 00 00 03 00 04 01 03 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
+#>  [1] 58 0a 00 00 00 03 00 04 02 00 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
 #> [26] 00 10 00 00 00 01 00 04 00 09 00 00 00 0c 68 65 6c 6c 6f 20 77 6f 72 6c 64
 #> [51] 21
 #> 
@@ -235,6 +235,7 @@ n$recv(mode = "double")
 massively-scaleable concurrency framework.
 
 ``` r
+
 s1 <- socket("pair", listen = "inproc://nano")
 s2 <- socket("pair", dial = "inproc://nano")
 ```
@@ -247,6 +248,7 @@ operation is ongoing, automatically resolving to a final value once
 complete.
 
 ``` r
+
 # an async receive is requested, but no messages are waiting (yet to be sent)
 msg <- recv_aio(s2)
 msg
@@ -260,6 +262,7 @@ msg$data
 For a ‘sendAio’ object, the result is stored at `$result`.
 
 ``` r
+
 res <- send_aio(s1, data.frame(a = 1, b = 2))
 res
 #> < sendAio >
@@ -276,12 +279,13 @@ For a ‘recvAio’ object, the message is stored at `$data`, and the raw
 message at `$raw` (if kept).
 
 ``` r
+
 # now that a message has been sent, the 'recvAio' automatically resolves
 msg$data
 #>   a b
 #> 1 1 2
 msg$raw
-#>   [1] 58 0a 00 00 00 03 00 04 01 03 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
+#>   [1] 58 0a 00 00 00 03 00 04 02 00 00 03 05 00 00 00 00 05 55 54 46 2d 38 00 00
 #>  [26] 03 13 00 00 00 02 00 00 00 0e 00 00 00 01 3f f0 00 00 00 00 00 00 00 00 00
 #>  [51] 0e 00 00 00 01 40 00 00 00 00 00 00 00 00 00 04 02 00 00 00 01 00 04 00 09
 #>  [76] 00 00 00 05 6e 61 6d 65 73 00 00 00 10 00 00 00 02 00 04 00 09 00 00 00 01
@@ -298,6 +302,7 @@ and after. This means there is no need to actually wait (block) for an
 Aio to resolve, as the example below demonstrates.
 
 ``` r
+
 msg <- recv_aio(s2)
 
 # unresolved() queries for resolution itself so no need to use it again within the while loop
@@ -317,6 +322,7 @@ The values may also be called explicitly using `call_aio()`. This will
 wait for completion of the Aio (blocking).
 
 ``` r
+
 # will wait for completion then return the resolved Aio
 call_aio(msg)
 
@@ -343,6 +349,7 @@ separate ‘server’ process running concurrently.
 function, in this case `rnorm()`, before sending back the result.
 
 ``` r
+
 library(nanonext)
 rep <- socket("rep", listen = "tcp://127.0.0.1:6546")
 ctxp <- context(rep)
@@ -353,6 +360,7 @@ reply(ctxp, execute = rnorm, send_mode = "raw")
 request and returns immediately with a `recvAio` object.
 
 ``` r
+
 library(nanonext)
 req <- socket("req", dial = "tcp://127.0.0.1:6546")
 ctxq <- context(req)
@@ -373,13 +381,14 @@ The return value from the server request is then retrieved and stored in
 the Aio as `$data`.
 
 ``` r
+
 call_aio(aio)
 
 aio
 #> < recvAio >
 #>  - $data for message data
 aio$data |> str()
-#>  num [1:100000000] -0.876 0.565 0.656 -1.265 -0.642 ...
+#>  num [1:100000000] 0.5354 0.1424 0.3993 0.0906 1.6356 ...
 ```
 
 As `call_aio()` is blocking and will wait for completion, an alternative
@@ -406,6 +415,7 @@ example. A subscriber can subscribe to one or multiple topics broadcast
 by a publisher.
 
 ``` r
+
 pub <- socket("pub", listen = "inproc://nanobroadcast")
 sub <- socket("sub", dial = "inproc://nanobroadcast")
 
@@ -454,6 +464,7 @@ itself is a timed event, and responses received after the timeout are
 discarded.
 
 ``` r
+
 sur <- socket("surveyor", listen = "inproc://nanoservice")
 res1 <- socket("respondent", dial = "inproc://nanoservice")
 res2 <- socket("respondent", dial = "inproc://nanoservice")
@@ -511,21 +522,23 @@ returning immediately with a ‘recvAio’.
 For normal use, it takes just the URL. It can follow redirects.
 
 ``` r
+
 ncurl("http://httpbin.org/headers")
 #> $raw
 #>   [1] 7b 0a 20 20 22 68 65 61 64 65 72 73 22 3a 20 7b 0a 20 20 20 20 22 48 6f 73
 #>  [26] 74 22 3a 20 22 68 74 74 70 62 69 6e 2e 6f 72 67 22 2c 20 0a 20 20 20 20 22
 #>  [51] 58 2d 41 6d 7a 6e 2d 54 72 61 63 65 2d 49 64 22 3a 20 22 52 6f 6f 74 3d 31
-#>  [76] 2d 36 32 36 61 62 33 31 37 2d 31 39 63 35 39 37 30 32 36 63 30 63 64 65 32
-#> [101] 63 36 32 61 37 33 39 35 35 22 0a 20 20 7d 0a 7d 0a
+#>  [76] 2d 36 32 36 64 62 31 35 33 2d 32 39 39 31 38 39 63 35 33 61 30 30 35 61 32
+#> [101] 38 32 33 65 31 34 38 62 37 22 0a 20 20 7d 0a 7d 0a
 #> 
 #> $data
-#> [1] "{\n  \"headers\": {\n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-626ab317-19c597026c0cde2c62a73955\"\n  }\n}\n"
+#> [1] "{\n  \"headers\": {\n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-626db153-299189c53a005a2823e148b7\"\n  }\n}\n"
 ```
 
 For advanced use, supports additional HTTP methods such as POST or PUT.
 
 ``` r
+
 res <- ncurl("http://httpbin.org/post", async = TRUE, method = "POST",
              headers = c(`Content-Type` = "application/json", Authorization = "Bearer APIKEY"),
              data = '{"key": "value"}')
@@ -535,7 +548,7 @@ res
 #>  - $raw for raw message
 
 call_aio(res)$data
-#> [1] "{\n  \"args\": {}, \n  \"data\": \"{\\\"key\\\": \\\"value\\\"}\", \n  \"files\": {}, \n  \"form\": {}, \n  \"headers\": {\n    \"Authorization\": \"Bearer APIKEY\", \n    \"Content-Length\": \"16\", \n    \"Content-Type\": \"application/json\", \n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-626ab317-57e5ea9a6c08c36277518b08\"\n  }, \n  \"json\": {\n    \"key\": \"value\"\n  }, \n  \"origin\": \"79.173.189.204\", \n  \"url\": \"http://httpbin.org/post\"\n}\n"
+#> [1] "{\n  \"args\": {}, \n  \"data\": \"{\\\"key\\\": \\\"value\\\"}\", \n  \"files\": {}, \n  \"form\": {}, \n  \"headers\": {\n    \"Authorization\": \"Bearer APIKEY\", \n    \"Content-Length\": \"16\", \n    \"Content-Type\": \"application/json\", \n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-626db153-400a5a4e7880ba63075877ec\"\n  }, \n  \"json\": {\n    \"key\": \"value\"\n  }, \n  \"origin\": \"78.145.225.121\", \n  \"url\": \"http://httpbin.org/post\"\n}\n"
 ```
 
 In this respect, it may be used as a performant and lightweight method
@@ -550,6 +563,7 @@ communicating with raw sockets. This may be used for connecting to
 arbitrary non-NNG endpoints.
 
 ``` r
+
 s <- stream(dial = "wss://demo.piesocket.com/v3/channel_1", textframes = TRUE)
 s
 #> < nanoStream >
@@ -619,13 +633,6 @@ set prior to installation if:
     want nanonext to download and build a more recent version of
     ‘libnng’ than available in system repositories against this.
 
-#### Certain ARM architectures
-
-If package installation initially fails with an error message of
-`unable to load shared object:[ ] undefined symbol: __atomic_fetch_sub_8`
-or similar, please set the environment variable
-`Sys.setenv(NANONEXT_ARM=1)` and then proceed with installation again.
-
 ### Links
 
 nanonext on CRAN: <https://cran.r-project.org/package=nanonext><br />

configure

@@ -3,16 +3,29 @@
 
 # set -x
 
+# Find compiler
+CC=`${R_HOME}/bin/R CMD config CC`
+CFLAGS=`${R_HOME}/bin/R CMD config CFLAGS`
+
 # Library settings
 PKG_TEST_HEADER="<nng/nng.h>"
 PKG_LIBS="-lnng"
 if [ "$NANONEXT_TLS" ]; then
   echo "trying with TLS support"
   PKG_LIBS="$PKG_LIBS -lmbedtls -lmbedx509 -lmbedcrypto"
 fi
-if [ "$NANONEXT_ARM" ]; then
+
+# Detect -latomic linker flag for e.g. ARM architectures (Raspberry Pi etc.)
+echo "#include <stdint.h>
+uint64_t v;
+int main() {
+    return (int)__atomic_load_n(&v, __ATOMIC_ACQUIRE);
+}" | ${CC} -x c - -o /dev/null > /dev/null 2>&1
+if [ $? -ne 0 ]; then
+  echo "adding -latomic linker flag"
   PKG_LIBS="$PKG_LIBS -latomic"
 fi
+
 PKG_CFLAGS=""
 LIB_VER="169221d"
 SYS_LIB=0
@@ -86,10 +99,6 @@ fi
 # echo "Using PKG_CFLAGS=$PKG_CFLAGS"
 # echo "Using PKG_LIBS=$PKG_LIBS"
 
-# Find compiler
-CC=`${R_HOME}/bin/R CMD config CC`
-CFLAGS=`${R_HOME}/bin/R CMD config CFLAGS`
-
 # Test for libnng
 echo "#include $PKG_TEST_HEADER" | ${CC} ${PKG_CFLAGS} ${CFLAGS} -E -xc - >/dev/null 2>&1