trace call on all errors and warnings

Author: shikokuchuo

NEWS.md

@@ -4,14 +4,14 @@
 
 * New `stream()` interface exposes low-level byte stream functionality in the NNG library, intended for communicating with non-NNG endpoints, including but not limited to websocket servers.
 * `ncurl()` adds an 'async' option to perform HTTP requests asynchronously, returning immediately with a 'recvAio'. Also adds explicit arguments for HTTP method, headers (which takes a named list or character vector) and request data.
-* New `messenger()` function implements a console-based 2-way messaging system using NNG's scalability protocols [currently experimental and undergoing testing].
+* New `messenger()` function implements a multi-threaded console-based messaging system using NNG's scalability protocols.
 
 #### Updates
 
 * Unified `send()` and `recv()` functions, and their asynchronous counterparts `send_aio()` and `recv_aio()`, are now S3 generics and can be used across Sockets, Contexts and Streams.
 * Revised 'block' argument for `send()` and `recv()` now allows an integer value for setting a timeout.
 * `send_ctx()` and `recv_ctx()` are deprecated and will be removed in a future package version - the methods for `send()` and `recv()` should be used instead.
-* Returned NNG error codes are now all classed 'errorValue' and messages have been upgraded to warnings across the package.
+* Returned NNG error codes are now all classed 'errorValue' and messages have been upgraded to warnings across the package to allow enhanced reporting of the originating call e.g. via `warnings()`. Timestamps have been removed in a trade-off for better performance.
 * Logging is deprecated and in the process of being phased out. Logging can still be set via 'NANONEXT_LOG' prior to package load but `logging()` can no longer be used. Logging will be removed entirely in a future package version.
 
 # nanonext 0.3.0

R/messenger.R

@@ -2,7 +2,8 @@
 
 #' Messenger
 #'
-#' Console-based 2-way messaging system based on NNG scalability protocols.
+#' Multi-threaded console-based 2-way messaging system based on NNG scalability
+#'     protocols.
 #'
 #' @param url a URL to connect to, specifying the transport and address as
 #'     a character string e.g. 'tcp://127.0.0.1:5555' (see \link{transports}).

README.md

@@ -370,7 +370,7 @@ aio
 #> < recvAio >
 #>  - $data for message data
 aio$data |> str()
-#>  num [1:100000000] 1.0489 0.7951 -0.5668 -0.1798 0.0081 ...
+#>  num [1:100000000] -0.17 -0.573 1.068 0.363 -0.864 ...
 ```
 
 As `call_aio()` is blocking and will wait for completion, an alternative
@@ -407,7 +407,8 @@ sub |> recv(mode = "character", keep.raw = FALSE)
 
 pub |> send(c("other", "this other topic will not be received"), mode = "raw", echo = FALSE)
 sub |> recv(mode = "character", keep.raw = FALSE)
-#> Warning: [ 8 ] Try again
+#> Warning in recv.nanoSocket(sub, mode = "character", keep.raw = FALSE): [ 8 ] Try
+#> again
 
 # specify NULL to subscribe to ALL topics
 sub |> subscribe(topic = NULL)
@@ -418,7 +419,7 @@ sub |> recv("character", keep.raw = FALSE)
 sub |> unsubscribe(topic = NULL)
 pub |> send(c("newTopic", "this topic will now not be received"), mode = "raw", echo = FALSE)
 sub |> recv("character", keep.raw = FALSE)
-#> Warning: [ 8 ] Try again
+#> Warning in recv.nanoSocket(sub, "character", keep.raw = FALSE): [ 8 ] Try again
 
 # however the topics explicitly subscribed to are still received
 pub |> send(c("examples", "this example will still be received"), mode = "raw", echo = FALSE)
@@ -474,7 +475,7 @@ aio2$data
 # after the survey expires, the second resolves into a timeout error
 Sys.sleep(0.5)
 aio2$data
-#> Warning: [ 5 ] Timed out
+#> Warning in (function (x) : [ 5 ] Timed out
 #> 'errorValue' int 5
 
 close(sur)
@@ -504,11 +505,11 @@ ncurl("http://httpbin.org/headers")
 #>   [1] 7b 0a 20 20 22 68 65 61 64 65 72 73 22 3a 20 7b 0a 20 20 20 20 22 48 6f 73
 #>  [26] 74 22 3a 20 22 68 74 74 70 62 69 6e 2e 6f 72 67 22 2c 20 0a 20 20 20 20 22
 #>  [51] 58 2d 41 6d 7a 6e 2d 54 72 61 63 65 2d 49 64 22 3a 20 22 52 6f 6f 74 3d 31
-#>  [76] 2d 36 32 34 63 39 66 31 32 2d 32 64 31 31 65 38 35 62 32 32 61 34 65 36 36
-#> [101] 66 31 38 63 62 32 66 31 36 22 0a 20 20 7d 0a 7d 0a
+#>  [76] 2d 36 32 34 63 62 66 66 38 2d 34 38 37 35 38 64 65 30 31 36 61 62 38 31 62
+#> [101] 34 36 38 39 31 32 66 37 61 22 0a 20 20 7d 0a 7d 0a
 #> 
 #> $data
-#> [1] "{\n  \"headers\": {\n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-624c9f12-2d11e85b22a4e66f18cb2f16\"\n  }\n}\n"
+#> [1] "{\n  \"headers\": {\n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-624cbff8-48758de016ab81b468912f7a\"\n  }\n}\n"
 ```
 
 For advanced use, supports additional HTTP methods such as POST or PUT.
@@ -523,7 +524,7 @@ res
 #>  - $raw for raw message
 
 call_aio(res)$data
-#> [1] "{\n  \"args\": {}, \n  \"data\": \"{\\\"key\\\": \\\"value\\\"}\", \n  \"files\": {}, \n  \"form\": {}, \n  \"headers\": {\n    \"Authorization\": \"Bearer APIKEY\", \n    \"Content-Length\": \"16\", \n    \"Content-Type\": \"application/json\", \n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-624c9f12-73d4984b4f201f7c28549806\"\n  }, \n  \"json\": {\n    \"key\": \"value\"\n  }, \n  \"origin\": \"78.145.225.121\", \n  \"url\": \"http://httpbin.org/post\"\n}\n"
+#> [1] "{\n  \"args\": {}, \n  \"data\": \"{\\\"key\\\": \\\"value\\\"}\", \n  \"files\": {}, \n  \"form\": {}, \n  \"headers\": {\n    \"Authorization\": \"Bearer APIKEY\", \n    \"Content-Length\": \"16\", \n    \"Content-Type\": \"application/json\", \n    \"Host\": \"httpbin.org\", \n    \"X-Amzn-Trace-Id\": \"Root=1-624cbff8-6717d2692cf3ae776109d3c9\"\n  }, \n  \"json\": {\n    \"key\": \"value\"\n  }, \n  \"origin\": \"79.173.189.204\", \n  \"url\": \"http://httpbin.org/post\"\n}\n"
 ```
 
 In this respect, it may be used as a performant and lightweight method

man/messenger.Rd

@@ -37,7 +37,7 @@ static SEXP mk_error(const int xc) {
 
   SEXP err = PROTECT(Rf_ScalarInteger(xc));
   Rf_classgets(err, Rf_mkString("errorValue"));
-  Rf_warningcall(R_NilValue, "[ %d ] %s", xc, nng_strerror(xc));
+  Rf_warning("[ %d ] %s", xc, nng_strerror(xc));
   UNPROTECT(1);
   return err;
 
@@ -445,9 +445,9 @@ SEXP rnng_stream_send_aio(SEXP stream, SEXP data, SEXP timeout) {
 SEXP rnng_aio_result(SEXP aio) {
 
   if (R_ExternalPtrTag(aio) != nano_AioSymbol)
-    error_return("'aio' is not a valid Aio");
+    error_return("object is not a valid Aio");
   if (R_ExternalPtrAddr(aio) == NULL)
-    error_return("'aio' is not an active Aio");
+    error_return("object is not an active Aio");
 
   uint8_t resolv;
   nano_aio *aiop = (nano_aio *) R_ExternalPtrAddr(aio);
@@ -469,9 +469,9 @@ SEXP rnng_aio_result(SEXP aio) {
 SEXP rnng_aio_get_msg(SEXP aio) {
 
   if (R_ExternalPtrTag(aio) != nano_AioSymbol)
-    error_return("'aio' is not a valid Aio");
+    error_return("object is not a valid Aio");
   if (R_ExternalPtrAddr(aio) == NULL)
-    error_return("'aio' is not an active Aio");
+    error_return("object is not an active Aio");
 
   uint8_t resolv;
   nano_aio *raio = (nano_aio *) R_ExternalPtrAddr(aio);
@@ -499,9 +499,9 @@ SEXP rnng_aio_get_msg(SEXP aio) {
 SEXP rnng_aio_stream_in(SEXP aio) {
 
   if (R_ExternalPtrTag(aio) != nano_AioSymbol)
-    error_return("'aio' is not a valid Aio");
+    error_return("object is not a valid Aio");
   if (R_ExternalPtrAddr(aio) == NULL)
-    error_return("'aio' is not an active Aio");
+    error_return("object is not an active Aio");
 
   uint8_t resolv;
   nano_aio *iaio = (nano_aio *) R_ExternalPtrAddr(aio);
@@ -550,13 +550,11 @@ SEXP rnng_aio_call(SEXP aio) {
 SEXP rnng_aio_stop(SEXP aio) {
 
   if (TYPEOF(aio) != ENVSXP)
-    error_return("'aio' is not a valid Aio");
+    error_return("object is not an active Aio");
 
   SEXP coreaio = Rf_findVarInFrame(aio, nano_AioSymbol);
-  if (R_ExternalPtrTag(coreaio) != nano_AioSymbol)
-    error_return("'aio' is not a valid Aio");
-  if (R_ExternalPtrAddr(coreaio) == NULL)
-    error_return("'aio' is not an active Aio");
+  if (R_ExternalPtrTag(coreaio) != nano_AioSymbol || R_ExternalPtrAddr(coreaio) == NULL)
+    error_return("object is not an active Aio");
 
   nano_aio *aiop = (nano_aio *) R_ExternalPtrAddr(coreaio);
   nng_aio_stop(aiop->aio);
@@ -788,9 +786,9 @@ SEXP rnng_ncurl_aio(SEXP http, SEXP method, SEXP headers, SEXP data) {
 SEXP rnng_aio_http(SEXP aio) {
 
   if (R_ExternalPtrTag(aio) != nano_AioSymbol)
-    error_return("'aio' is not a valid Aio");
+    errorcall_return(R_NilValue, "object is not a valid Aio");
   if (R_ExternalPtrAddr(aio) == NULL)
-    error_return("'aio' is not an active Aio");
+    errorcall_return(R_NilValue, "object is not an active Aio");
 
   uint8_t resolv;
   nano_aio *haio = (nano_aio *) R_ExternalPtrAddr(aio);

src/aio.c

@@ -9,7 +9,7 @@ static SEXP mk_error(const int xc) {
 
   SEXP err = PROTECT(Rf_ScalarInteger(xc));
   Rf_classgets(err, Rf_mkString("errorValue"));
-  Rf_warningcall(R_NilValue, "[ %d ] %s", xc, nng_strerror(xc));
+  Rf_warning("[ %d ] %s", xc, nng_strerror(xc));
   UNPROTECT(1);
   return err;
 

src/core.c

@@ -9,7 +9,7 @@ static SEXP mk_error(const int xc) {
 
   SEXP err = PROTECT(Rf_ScalarInteger(xc));
   Rf_classgets(err, Rf_mkString("errorValue"));
-  Rf_warningcall(R_NilValue, "[ %d ] %s", xc, nng_strerror(xc));
+  Rf_warning("[ %d ] %s", xc, nng_strerror(xc));
   UNPROTECT(1);
   return err;
 

src/opts.c

@@ -21,7 +21,7 @@ static SEXP mk_error(const int xc) {
 
   SEXP err = PROTECT(Rf_ScalarInteger(xc));
   Rf_classgets(err, Rf_mkString("errorValue"));
-  Rf_warningcall(R_NilValue, "[ %d ] %s", xc, nng_strerror(xc));
+  Rf_warning("[ %d ] %s", xc, nng_strerror(xc));
   UNPROTECT(1);
   return err;
 

src/sockets.c

@@ -11,7 +11,7 @@ static SEXP mk_error(const int xc) {
 
   SEXP err = PROTECT(Rf_ScalarInteger(xc));
   Rf_classgets(err, Rf_mkString("errorValue"));
-  Rf_warningcall(R_NilValue, "[ %d ] %s", xc, nng_strerror(xc));
+  Rf_warning("[ %d ] %s", xc, nng_strerror(xc));
   UNPROTECT(1);
   return err;