Bug: use_bioconductor = FALSE still contacts bioconductor.org

Author: SermetPekin

.gitignore

@@ -47,3 +47,4 @@
 /vignettes/internals.html
 /vignettes/internals.md
 /.dev
+bug-report-use-bioconductor.md

NEWS.md

@@ -1,5 +1,14 @@
 # pak (development version)
 
+* Setting `use_bioconductor = FALSE` (or `options(pkg.use_bioconductor = FALSE)`)
+  now truly prevents any network contact with Bioconductor. Previously,
+  `cmc__get_repos()` in pkgcache unconditionally called
+  `bioconductor$get_repos()` to classify repository types — even when
+  `bioc = FALSE` — which could trigger an HTTP request to
+  `https://bioconductor.org/config.yaml` for R versions not in the
+  built-in R → Bioc version map (e.g. R 4.5). This request causes a hard
+  failure behind corporate firewalls (#TODO).
+
 # pak 0.9.2
 
 * No user visible changes.

src/library/pkgcache/R/metadata-cache.R

@@ -1040,7 +1040,7 @@ extract_revdeps <- function(pkgs, packages, dependencies, recursive) {
 cmc__get_repos <- function(repos, bioc, cran_mirror, r_version, auth = TRUE) {
   repos[["CRAN"]] <- cran_mirror
   repos <- unlist(repos)
-  bioc_names <- bioconductor$get_repos()
+  bioc_names <- if (bioc) bioconductor$get_repos() else character(0L)
   res <- data_frame(
     name = names(repos),
     url = unname(repos),