add test and fix for untested thing 🫠

Author: maelle

R/build-llm.R

@@ -74,10 +74,14 @@ create_absolute_links <- function(main_html, pkg) {
     if (pkg$development$in_dev && pkg$bs_version > 3) {
       url <- paste0(url, pkg$prefix)
     }
-    a_external <- a[!grepl("external-link", xml2::xml_attr(a, "class"))]
+    a_internal <- a[
+      !startsWith(xml2::xml_attr(a, "href"), "https") &
+        !startsWith(xml2::xml_attr(a, "href"), "#")
+    ]
 
-    href_absolute <- xml2::url_absolute(xml2::xml_attr(a_external, "href"), url)
+    href_absolute <- xml2::url_absolute(xml2::xml_attr(a_internal, "href"), url)
     href_absolute <- path_ext_set(href_absolute, "md")
+    xml2::xml_attr(a_internal, "href") <- href_absolute
   }
   xml2::xml_attr(a, "class") <- NULL
 }

tests/testthat/_snaps/build-llm/llm.md

@@ -31,6 +31,13 @@ GitHub repository from the package (e.g. with
 [`usethis::use_github()`](https://usethis.r-lib.org/reference/use_github.html)),
 and file an issue with a link to the repository.
 
+pkgdown is designed to make it quick and easy to build a website for
+your package. You can see pkgdown in action at
+<https://pkgdown.r-lib.org>: this is the output of pkgdown applied to
+the latest version of pkgdown. Learn more in
+[`vignette("pkgdown")`](https:/pkgdown.r-lib.org/articles/pkgdown.md) or
+[`?build_site`](https:/pkgdown.r-lib.org/reference/build_site.md).
+
 ------------------------------------------------------------------------
 
 1.  Note that dots (`.`) in the package name need to be replaced by

tests/testthat/assets/llm.html

@@ -34,4 +34,11 @@
 </div>
 <div class
 
+<p>pkgdown is designed to make it quick and easy to build a website for your package. 
+  You can see pkgdown in action at <a href="https://pkgdown.r-lib.org" class="uri">https://pkgdown.r-lib.org</a>: 
+  this is the output of pkgdown applied to the latest version of pkgdown. 
+  Learn more in <code><a href="articles/pkgdown.html">vignette("pkgdown")</a></code> 
+  or <code><a href="reference/build_site.html">?build_site</a></code>.</p>
+
+
 </main>

tests/testthat/test-build-llm.R

@@ -19,6 +19,7 @@ test_that("build_llm_docs() works", {
 test_that("convert_md() works", {
   skip_if_no_pandoc()
   pkg <- local_pkgdown_site()
+  pkg$meta$url <- "https://pkgdown.r-lib.org"
 
   dir <- withr::local_tempdir()
   pkg$dst_path <- dir