feat: Use bslib's navbar Sass variables, if present#2847
Merged
jayhesselberth merged 3 commits intor-lib:mainfrom Jan 29, 2025
Merged
feat: Use bslib's navbar Sass variables, if present#2847jayhesselberth merged 3 commits intor-lib:mainfrom
jayhesselberth merged 3 commits intor-lib:mainfrom
Conversation
Collaborator
|
Could you add a news bullet? THanks |
Contributor
Author
Sure! I also updated the documentation in the customise article to
|
Contributor
|
This is great - this pretty much closes my request in issue #2703, so you might like to add that as a linked issue. |
Collaborator
|
Thanks! |
Bisaloo
added a commit
to epiverse-trace/epiversetheme
that referenced
this pull request
Jan 30, 2025
Bisaloo
added a commit
to epiverse-trace/epiversetheme
that referenced
this pull request
Apr 28, 2025
Bisaloo
added a commit
to epiverse-trace/epiversetheme
that referenced
this pull request
Apr 28, 2025
Bisaloo
added a commit
to epiverse-trace/epiversetheme
that referenced
this pull request
Apr 28, 2025
Bisaloo
added a commit
to epiverse-trace/epiversetheme
that referenced
this pull request
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bslib patches Bootstrap to add three Sass variables:
$navbar-bg,$navbar-light-bgand$navbar-dark-bg(see e.g. bslib's Boostrap 5_variables.scssfile).This PR updates pkgdown's Sass so that
$pkgdown-navbar-bgand$pkgdown-navbar-bg-darkinherit the (default) values from bslib so that the same Sass variables can be used in Shiny, Quarto and pkgdown.This change shouldn't affect anyone who is already using the pkgdown Sass variables as these will take precedence over bslib's navbar bg vars.
Fixes #2703