Merged
Conversation
maelle
commented
Feb 4, 2025
| } | ||
| // ror badge | ||
| .ror { | ||
| height: 16px; |
Collaborator
Author
There was a problem hiding this comment.
maybe it should be bigger
Collaborator
There was a problem hiding this comment.
16px seems like a fine place to start
Collaborator
Author
|
|
Collaborator
|
@maelle This looks good, did you want to do anything else before mergine? |
Collaborator
|
@maelle Can you add a news bullet? |
Collaborator
Author
|
@jayhesselberth Thank you! Not sure why I had left it as draft. 😅 In any case I was waiting for a review 😁 |
jayhesselberth
approved these changes
Feb 28, 2025
|
|
||
| paste0( | ||
| "<a href='https://ror.org/", ror, "'>", | ||
| "<img src='https://raw.githubusercontent.com/ror-community/ror-logos/main/ror-icon-rgb.svg' class='ror' alt='ROR'></a>" |
Collaborator
There was a problem hiding this comment.
Should we use the version with transparent background?
https://github.com/ror-community/ror-logos/blob/main/ror-icon-rgb-transparent.svg
Collaborator
Author
There was a problem hiding this comment.
wouldn't it look worse in dark mode?
| } | ||
| // ror badge | ||
| .ror { | ||
| height: 16px; |
Collaborator
There was a problem hiding this comment.
16px seems like a fine place to start
Collaborator
|
Thanks! |
Collaborator
Author
|
Thank you! |
cjyetman
added a commit
to RMI-PACTA/pacta.loanbook
that referenced
this pull request
Apr 8, 2025
Apparently RMI has a [Research Organization Registry (ROR) ID](https://ror.org/03anfar33), CRAN is now [automatically linking them](https://bsky.app/profile/zeileis.org/post/3lgpshnevkk2v), and pkgdown will [auto link them soon](r-lib/pkgdown#2851).
cjyetman
added a commit
to RMI-PACTA/pacta.loanbook
that referenced
this pull request
Apr 8, 2025
Apparently RMI has a [Research Organization Registry (ROR) ID](https://ror.org/03anfar33), CRAN is now [automatically linking them](https://bsky.app/profile/zeileis.org/post/3lgpshnevkk2v), and pkgdown will [auto link them soon](r-lib/pkgdown#2851).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2850