Add CSS filter for auto-dark figures#2919
Merged
jayhesselberth merged 2 commits intomainfrom Oct 7, 2025
Merged
Conversation
Thanks to @gadenbuie Fixes #2729. Closes #2854
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
Not sure why I can't add you as a reviewer @gadenbuie — can you take a look? |
gadenbuie
approved these changes
Oct 7, 2025
Contributor
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
This looks great to me! It'd be nice if the example plots involved a little bit of color to make sure the filters make sense.
I think your comment in the previous PR about differentiating between markdown images and rendered images is worth considering, but I took a quick look at knitr options and didn't find an immediately obvious way to do that...
Collaborator
Author
|
Here's the transformed plot with added color: 
|
Collaborator
Author
|
Also FWIW confirmed to work on firefox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @gadenbuie
Fixes #2729. Closes #2854