`build_favicons()` creates truncated favicon.ico

[peterdesmet]

A package logo is typically a logo.png file that is higher than wide (i.e. not square). The pkgdown logo for example has a height of 277px and a width of 240px:

Using build_favicons() on such a logo results in a favicon.ico with a truncated top and bottom:

I believe that is because the favicon.ico generator server expects a square input file. If you manually extend the canvas width of logo.png to 277px (resulting in a square file), the favicon.ico looks correct:

Is this something that could be done automatically by build_favicons() before sending the logo.png to the favicon.ico generator?

---

Note: the other favicons the function generates (e.g. apple-touch-icon.png) don't have this issue.

[jayhesselberth]

Not intentional. It's possible we have been wrong from the start, or the favicon generator may have changed (afaicr they don't keep a changelog, so you have to dig through commits here: https://github.com/RealFaviconGenerator/core)