Merge pull request #1149 from r-lib/fix-lints-sep23

Clean new lints

Author: IndrajeetPatil

R/rules-indention.R

@@ -20,7 +20,7 @@ indent_braces <- function(pd, indent_by) {
 #' @keywords internal
 unindent_fun_dec <- function(pd, indent_by = 2L) {
   if (is_function_declaration(pd)) {
-    idx_closing_brace <- which(pd$token %in% "')'")
+    idx_closing_brace <- which(pd$token == "')'")
     fun_dec_head <- seq2(2L, idx_closing_brace)
     if (is_double_indent_function_declaration(pd, indent_by = indent_by)) {
       pd$indent[fun_dec_head] <- 2L * indent_by

R/rules-line-breaks.R

@@ -153,7 +153,6 @@ style_line_break_around_curly <- function(strict, pd) {
     closing_before <- pd$token == "'}'"
     opening_before <- (pd$token == "'{'")
     to_break <- lag(opening_before, default = FALSE) | closing_before
-    len_to_break <- sum(to_break)
     pd$lag_newlines[to_break] <- ifelse(
       pd$token[to_break] == "COMMENT",
       pmin(1L, pd$lag_newlines[to_break]),

R/transform-files.R

@@ -116,9 +116,12 @@ make_transformer <- function(transformers,
       use_cache <- FALSE
     }
 
-    if (!use_cache) {
+    if (use_cache) {
+      text
+    } else {
       transformed_code <- text %>%
-        parse_transform_serialize_r(transformers,
+        parse_transform_serialize_r(
+          transformers,
           base_indention = base_indention,
           warn_empty = warn_empty
         )
@@ -139,8 +142,6 @@ make_transformer <- function(transformers,
       }
 
       transformed_code
-    } else {
-      text
     }
   }
 }