creating tokens must respect stylerignore

Author: lorenzwalthert

NEWS.md

@@ -27,6 +27,7 @@
 
 * Piped function without brackets `substitute(x %>% y)` don't get `()` added
   anymore, as this can change outcome of the code (#876).
+* rules that add tokens don't break stylerignore sequences anymore (#891).
 * Add vignette on distributing style guide (#846, #861).
 * Alignment detection respects stylerignore (#850).
 * `Warning: Unknown or uninitialised column:` was fixed (#885).
@@ -35,9 +36,9 @@
 * ensure a trailing blank line also if the input is cached (#867).
 * Preserve trailing blank line in roxygen examples to simplify concatenation of
   examples (#880).
-* Fix argument name `filetype` in Example for `style_dir()` (#855).
 * An error is now thrown on styling if input unicode characters can't be 
   correctly parsed for Windows and R < 4.2 (#883).
+* Fix argument name `filetype` in Example for `style_dir()` (#855).
 
 
 **Infrastructure**

R/rules-tokens.R

@@ -35,10 +35,21 @@ add_brackets_in_pipe_one <- function(pd, pos) {
     child <- pd$child[[next_non_comment]]
     new_pos_ids <- create_pos_ids(child, 1, after = TRUE, n = 2)
     new_pd <- create_tokens(
-      tokens = c("'('", "')'"),
       texts = c("(", ")"),
+      lag_newlines = rep(0L, 2),
+      spaces = 0,
       pos_ids = new_pos_ids,
-      lag_newlines = rep(0L, 2)
+      token_before = c(child$token[1], "'('"),
+      token_after = c("')'", child$token_after[1]),
+      indention_ref_pos_ids = NA,
+      indents = child$indent[1],
+      tokens = c("'('", "')'"),
+      terminal = TRUE,
+      child = NULL,
+      stylerignore = child$stylerignore[1],
+      # block???
+      block = NA,
+      is_cached = FALSE
     )
     pd$child[[next_non_comment]] <- bind_rows(
       pd$child[[next_non_comment]],

tests/testthat/token_adding_removing/add_brackets_in_pipe-stylerignore-in.R

@@ -0,0 +1,54 @@
+# styler: off
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A() %>% # comment
+    tjnfaxdfaasfaf7987A() %>%
+    tjnfxasfaf798fA() %>%
+    tf797A() %>% # more
+    # comment
+    yyexprzB()
+})
+# styler: on
+
+
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A() %>% # comment
+    tjnfaxdfaasfaf7987A() %>%
+    tjnfxasfaf798fA() %>%
+    tf797A() %>% # more
+    # comment
+    yyexprzB()
+})
+
+
+# styler: off
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A %>%
+    tjnfaxdfaasfaf7987A %>%
+    tjnfxasfaf798fA %>%
+    # more
+    tf797A %>% # comments
+    # here
+    yyexprzB #
+  # whatnot
+})
+# styler: on
+
+
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A %>%
+    tjnfaxdfaasfaf7987A %>%
+    tjnfxasfaf798fA %>%
+    # more
+    tf797A %>% # comments
+    # here
+    yyexprzB #
+  # whatnot
+})

tests/testthat/token_adding_removing/add_brackets_in_pipe-stylerignore-in_tree

@@ -0,0 +1,54 @@
+# styler: off
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A() %>% # comment
+    tjnfaxdfaasfaf7987A() %>%
+    tjnfxasfaf798fA() %>%
+    tf797A() %>% # more
+    # comment
+    yyexprzB()
+})
+# styler: on
+
+
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A() %>% # comment
+    tjnfaxdfaasfaf7987A() %>%
+    tjnfxasfaf798fA() %>%
+    tf797A() %>% # more
+    # comment
+    yyexprzB()
+})
+
+
+# styler: off
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A %>%
+    tjnfaxdfaasfaf7987A %>%
+    tjnfxasfaf798fA %>%
+    # more
+    tf797A %>% # comments
+    # here
+    yyexprzB #
+  # whatnot
+})
+# styler: on
+
+
+aflh({
+  isfris %>%
+    # comment
+    tjnfaxasf12af7987A() %>%
+    tjnfaxdfaasfaf7987A() %>%
+    tjnfxasfaf798fA() %>%
+    # more
+    tf797A() %>% # comments
+    # here
+    yyexprzB() #
+  # whatnot
+})