indent deeply-nested EQ_FORMALS correctly

Problem: In apply_ref_indention_one(), the parse table is already flat, the indention of all tokens is absolute. However, for those where indention should be copied from another token, their indention must be relative, otherwise we'll double account for some indention. See tests: Formals need to be aligned with the absolute indention of the opening brace. If you add another time their absolute indention, they will be indented way to much.

Solution: When flattening the parse table, keep the indention level of all tokens that have a ref_pos_id relative, so when added with an absolute indention, it will become absolute indention.

Author: lorenzwalthert

R/visit.R

@@ -74,7 +74,9 @@ context_to_terminals <- function(pd_nested,
   }
 
   pd_transformed <- context_towards_terminals(
-    pd_nested, outer_lag_newlines, outer_indent, outer_spaces, outer_indention_refs
+    pd_nested,
+    outer_lag_newlines, outer_indent,
+    outer_spaces, outer_indention_refs
   )
 
   pd_transformed$child <- pmap(
@@ -110,7 +112,11 @@ context_towards_terminals <- function(pd_nested,
                                       outer_indent,
                                       outer_spaces,
                                       outer_indention_refs) {
-  pd_nested$indent <- pd_nested$indent + outer_indent
+  pd_nested$indent <- pd_nested$indent + ifelse(
+    is.na(pd_nested$indention_ref_pos_id),
+    outer_indent,
+    0
+  )
   ref_pos_id_is_na <- !is.na(pd_nested$indention_ref_pos_id)
   pd_nested$indention_ref_pos_id[!ref_pos_id_is_na] <- outer_indention_refs
   pd_nested$lag_newlines[1] <- pd_nested$lag_newlines[1] + outer_lag_newlines

tests/testthat/indention_operators/eq_sub_complex_indention-in.R

@@ -6,3 +6,27 @@ call(a =
        5,
      b
      )
+
+# multiple nested levels
+{
+  v <- function(x =
+  122,
+  y) {
+       }
+}
+
+
+{
+        v <- function(x = 122,
+                      y) {
+        }
+}
+
+MyClass <- R6::R6Class(
+        "MyClass",
+        public = list(initialize = function(my_arg,
+                                            my_named_arg = 1) {
+                return(invisible())
+        }
+        ),
+)

tests/testthat/indention_operators/eq_sub_complex_indention-in_tree

@@ -6,3 +6,27 @@ call(a =
   5,
 b
 )
+
+# multiple nested levels
+{
+  v <- function(x =
+                  122,
+                y) {
+  }
+}
+
+
+{
+  v <- function(x = 122,
+                y) {
+  }
+}
+
+MyClass <- R6::R6Class(
+  "MyClass",
+  public = list(initialize = function(my_arg,
+                                      my_named_arg = 1) {
+    return(invisible())
+  }
+  ),
+)