Merge pull request #689 from lorenzwalthert/update-news

- Update news (#689).

Author: lorenzwalthert

NEWS.md

@@ -27,7 +27,15 @@
 - empty lines are now removed between pipes (#645).
 - overhaul pgkdown site: Add search (#623), group function in Reference (#625).
 - always strip trailing spaces and make cache insensitive to it (#626).
-- minor documentation improvements (#643, #618, #614, #677).
+- minor documentation improvements (#643, #618, #614, #677, #651, #667, #672, 
+  #687).
+- The internal `create_tree()` only used in testing of styler now works when the 
+  cache is activated (#688).
+
+## Infrastructure changes
+
+- switched from travis and AppVeyor to GitHub Actions (#653, #660).
+- Added basic continuous benchmarking (#674, #684).
 
 # styler 1.3.2
 

bench/01-declarations.R

@@ -18,16 +18,18 @@ plot_against_base <- function(new_bm,
     # if a pull request
     reference <- bm[commit_is_reference, "benchmarks"][[1]][[1]]
     # if benchmark exists in base branch
-    reference <- reference %>%
-      dplyr::filter(.data$name %in% !!name)
-    if (nrow(reference) > 0) {
-      # if benchmark exists in base branch
-      reference$expression <- bench:::new_bench_expr(Sys.getenv("GITHUB_BASE_REF"))
-      new_bm <- dplyr::bind_rows(reference, new_bm)
-      stopifnot(nrow(new_bm) == 2)
-      diff_in_percent <- round(100 * diff(new_bm$p50) / new_bm$p50[1])
-      pr_comment <- glue::glue("* {name}: {new_bm$p50[1]} -> {new_bm$p50[2]} ({diff_in_percent}%)\n")
-      cat(pr_comment, file = "pr-comment/info.txt", append = TRUE)
+    if ("name" %in% names(reference)) {
+      reference <- reference %>%
+        dplyr::filter(.data$name %in% !!name)
+      if (nrow(reference) > 0) {
+        # if benchmark exists in base branch
+        reference$expression <- bench:::new_bench_expr(Sys.getenv("GITHUB_BASE_REF"))
+        new_bm <- dplyr::bind_rows(reference, new_bm)
+        stopifnot(nrow(new_bm) == 2)
+        diff_in_percent <- round(100 * diff(new_bm$p50) / new_bm$p50[1])
+        pr_comment <- glue::glue("* {name}: {new_bm$p50[1]} -> {new_bm$p50[2]} ({diff_in_percent}%)\n")
+        cat(pr_comment, file = "pr-comment/info.txt", append = TRUE)
+      }
     }
   }
   new_bm$branch <- factor(new_bm$expression)