remove spaces in square subsetting expressions

Author: lorenzwalthert

R/rules-spacing.R

@@ -171,7 +171,7 @@ remove_space_before_opening_paren <- function(pd_flat) {
 }
 
 remove_space_after_opening_paren <- function(pd_flat) {
-  paren_after <- pd_flat$token == "'('"
+  paren_after <- pd_flat$token %in% c("'('", "'['", "LBB")
   if (!any(paren_after)) {
     return(pd_flat)
   }
@@ -180,7 +180,7 @@ remove_space_after_opening_paren <- function(pd_flat) {
 }
 
 remove_space_before_closing_paren <- function(pd_flat) {
-  paren_after <- pd_flat$token == "')'"
+  paren_after <- pd_flat$token %in% c("')'", "']'")
   if (!any(paren_after)) {
     return(pd_flat)
   }

tests/testthat/spacing/spacing-square-in.R

@@ -0,0 +1,14 @@
+a[[2]]
+a[[2 ]]
+
+a[[ 2]]
+
+a[[ 2 ]]
+
+
+a[2]
+a[2 ]
+
+a[ 2]
+
+a[ 2 ]

tests/testthat/spacing/spacing-square-in_tree

@@ -0,0 +1,14 @@
+a[[2]]
+a[[2]]
+
+a[[2]]
+
+a[[2]]
+
+
+a[2]
+a[2]
+
+a[2]
+
+a[2]

tests/testthat/spacing/spacing-square-out.R

@@ -62,5 +62,10 @@ test_that("spacing around tilde", {
     transformer = style_text, strict = TRUE), NA)
 })
 
+test_that("spacing around square brackets / braces", {
+  expect_warning(test_collection(
+    "spacing", "spacing-square",
+    transformer = style_text, strict = TRUE), NA)
+})