make sure that when cache is deactivated and R.cache is installed but there is no R.cache premanent directory, the user is never asked about setting up a permanent directory.

Author: lorenzwalthert

R/communicate.R

@@ -38,15 +38,10 @@ assert_data.tree_installation <- function() {
 #' Assert the R.cache installation in conjunction with the cache config
 #'
 #' R.cache needs to be installed if caching functionality is enabled
-#' @param installation_only Whether or not to only check if R.cache is
-#'   installed.
 #' @keywords internal
-assert_R.cache_installation <- function(installation_only = FALSE,
-                                        action = "abort") {
+assert_R.cache_installation <- function(action = "abort") {
   # fail if R.cache is not installed but feature is actiavted.
-  if (!rlang::is_installed("R.cache") &&
-    ifelse(installation_only, TRUE, cache_is_activated())
-  ) {
+  if (!rlang::is_installed("R.cache")) {
     msg_basic <- paste(
       "R package R.cache is not installed, which is needed when the caching ",
       "feature is activated. Please install the package with ",

R/transform-files.R

@@ -78,12 +78,10 @@ make_transformer <- function(transformers,
                              warn_empty = TRUE) {
   force(transformers)
   assert_transformers(transformers)
-  assert_R.cache_installation(action = "warn")
-
-  is_R.cache_installed <- rlang::is_installed("R.cache")
+  if (cache_is_activated()) assert_R.cache_installation(action = "warn")
 
   function(text) {
-    should_use_cache <- is_R.cache_installed && cache_is_activated()
+    should_use_cache <- cache_is_activated() && rlang::is_installed("R.cache")
 
     if (should_use_cache) {
       use_cache <- is_cached(text, transformers)

R/ui-caching.R

@@ -14,7 +14,7 @@
 #' @family cache managers
 #' @export
 cache_clear <- function(cache_name = NULL, ask = TRUE) {
-  assert_R.cache_installation(installation_only = TRUE)
+  assert_R.cache_installation()
   path_cache <- cache_find_path(cache_name)
   R.cache::clearCache(path_cache, prompt = ask)
   cache_deactivate(verbose = FALSE)
@@ -50,7 +50,7 @@ NULL
 #' @family cache managers
 #' @export
 cache_info <- function(cache_name = NULL, format = "both") {
-  assert_R.cache_installation(installation_only = TRUE)
+  assert_R.cache_installation()
   rlang::arg_match(format, c("tabular", "lucid", "both"))
   path_cache <- cache_find_path(cache_name)
   files <- list.files(path_cache, full.names = TRUE)
@@ -92,7 +92,7 @@ cache_info <- function(cache_name = NULL, format = "both") {
 #' @family cache managers
 #' @export
 cache_activate <- function(cache_name = NULL, verbose = TRUE) {
-  assert_R.cache_installation(installation_only = TRUE)
+  assert_R.cache_installation()
   if (!is.null(cache_name)) {
     options("styler.cache_name" = cache_name)
   } else {

man/assert_R.cache_installation.Rd

@@ -4,33 +4,46 @@ test_that("Cache management fails mostly when R.cache is not installed", {
   expect_error(activate_testthat_cache(), "is needed when the caching feature is activated")
   expect_error(cache_clear("testthat"), "is needed when the caching feature is activated")
   expect_error(capture.output(cache_deactivate()), NA)
-  expect_silent(assert_R.cache_installation())
   expect_error(
-    assert_R.cache_installation(installation_only = TRUE),
+    assert_R.cache_installation(),
     "is needed when the caching feature is activated"
   )
 })
 
 
 test_that("styling works when R.cache is not installed", {
   skip_if(rlang::is_installed("R.cache"))
+  # no warning when cache is disabled manually
+  expect_output(
+      withr::with_options(
+        # simulate .onLoad() in fresh R session
+        list(styler.cache_name = styler_version),
+        {
+          cache_deactivate()
+          style_text("1+1")
+        }
+    ),
+    "Deactivated cache."
+  )
+
+  # warning if cache is not disabled manually
   # warning for first time
   expect_warning(
     capture.output(
       withr::with_options(
         # simulate .onLoad() in fresh R session
-        list(styler.cache_name = cache_derive_name()),
+        list(styler.cache_name = styler_version),
         style_text("1+1")
       )
     ),
-    "Deactivating the caching feature for the current session"
+    "R package R.cache .*Deactivating the caching feature for the current session"
   )
 
   # No warnings subsequently
   expect_warning(
     capture.output(
       withr::with_options(
-        list(styler.cache_name = cache_derive_name()), {
+        list(styler.cache_name = styler_version), {
           suppressWarnings(style_text("1+1"))
           style_text("1+1")
         }