Skip to content

Commit ca400ad

Browse files
Merge pull request #1143 from r-lib/fix-cran-warning
Fix CRAN warning on invalid numeric version inputs
2 parents 1fc5b13 + 922573c commit ca400ad

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/check-full.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656
- uses: r-lib/actions/check-r-package@v2
5757
with:
5858
upload-snapshots: true
59-
error-on: 'ifelse(getRversion() > 3.6, "warning", "note")'
59+
error-on: 'ifelse(getRversion() > "3.6", "warning", "note")'
6060
env:
6161
_R_CHECK_FORCE_SUGGESTS_: false
62+
_R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_: true

R/set-assert-args.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ set_arg_write_tree <- function(write_tree) {
2121
#' @inheritParams make_transformer
2222
#' @keywords internal
2323
assert_transformers <- function(transformers) {
24-
version_cutoff <- 2.0
24+
version_cutoff <- "2.0"
2525
no_name <- is.null(transformers$style_guide_name)
2626
no_version <- is.null(transformers$style_guide_version)
2727
if (no_name || no_version) {

0 commit comments

Comments
 (0)