improve terminology

Author: lorenzwalthert

bench/01-declarations.R

@@ -1,20 +1,19 @@
-#' Plot benchmarks against master, if benchmarks there exist
-#'
+#' Plot benchmarks against a base branch, if benchmarks there exist
 #'
 #' @param new_bm A new benchmark object.
 #' @param new_bm_label The label of the new benchmark used as a title.
 #' @param file The file path to write the plot.
-plot_against_master <- function(new_bm,
-                                new_bm_label = deparse(substitute(new_bm)),
-                                file = paste0("plots/", new_bm_label, ".pdf")) {
+plot_against_base <- function(new_bm,
+                              new_bm_label = deparse(substitute(new_bm)),
+                              file = paste0("plots/", new_bm_label, ".pdf")) {
   new_bm <- bench::as_bench_mark(new_bm)
   branches <- gert::git_branch_list()
-  master <- branches[branches$name == "master", "commit", drop = TRUE]
+  last_commit_base_branch <- branches[branches$name == Sys.getenv("GITHUB_BASE_REF"), "commit", drop = TRUE]
   bm <- bench::cb_read()
-  hash_is_master <- bm$commit_hash == master
-  if (any(hash_is_master) && Sys.getenv("GITHUB_BASE_REF") != "") {
+  commit_is_reference <- bm$commit_hash == last_commit_base_branch
+  if (any(commit_is_reference) && Sys.getenv("GITHUB_BASE_REF") != "") {
     # if a pull request
-    reference <- bm[hash_is_master, "benchmarks"][[1]][[1]]
+    reference <- bm[commit_is_reference, "benchmarks"][[1]][[1]]
     reference$expression <- bench:::new_bench_expr(Sys.getenv("GITHUB_BASE_REF"))
     new_bm$expression <- bench:::new_bench_expr(Sys.getenv("GITHUB_HEAD_REF"))
     new_bm <- rbind(reference, new_bm)