Skip to content

Commit da849bc

Browse files
committed
All transformers are named
1 parent 1f4437b commit da849bc

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

R/testing.R

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,9 @@ NULL
164164
style_empty <- function(text, base_indention = 0) {
165165
transformers <- list(
166166
# transformer functions
167-
initialize = default_style_guide_attributes,
167+
initialize = list(
168+
default_style_guide_attributes = default_style_guide_attributes
169+
),
168170
line_break = NULL,
169171
space = NULL,
170172
token = NULL,
@@ -186,9 +188,13 @@ style_empty <- function(text, base_indention = 0) {
186188
style_op <- function(text, base_indention = 0L) {
187189
transformers <- list(
188190
# transformer functions
189-
initialize = default_style_guide_attributes,
191+
initialize = list(
192+
default_style_guide_attributes = default_style_guide_attributes
193+
),
190194
line_break = NULL,
191-
space = partial(indent_op, indent_by = 2L),
195+
space = list(
196+
indent_op = partial(indent_op, indent_by = 2L)
197+
),
192198
token = NULL,
193199
# transformer options
194200
use_raw_indention = FALSE,

R/transform-files.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,8 +346,9 @@ apply_transformers <- function(pd_nested, transformers) {
346346
transformed_updated_multi_line <- post_visit(
347347
pd_nested,
348348
c(
349-
transformers$initialize, transformers$line_break, set_multi_line,
350-
if (length(transformers$line_break) != 0) update_newlines
349+
transformers$initialize, transformers$line_break,
350+
set_multi_line = set_multi_line,
351+
update_newlines = if (length(transformers$line_break) != 0) update_newlines
351352
)
352353
)
353354

R/visit.R

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ post_visit_one <- function(pd_nested, fun) {
106106
#' @family visitors
107107
#' @keywords internal
108108
visit_one <- function(pd_flat, funs) {
109+
stopifnot(!is.null(names(funs)))
110+
stopifnot(all(names(funs) != ""))
109111
for (f in funs) {
110112
pd_flat <- f(pd_flat)
111113
}

tests/testthat/test-indent-character.R

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
test_that("indention character can be arbitrary", {
22
sg <- function(indent_by = 1) {
33
create_style_guide(
4-
indention = list(purrr::partial(indent_braces, indent_by = indent_by)),
4+
indention = list(
5+
indent_braces = purrr::partial(indent_braces, indent_by = indent_by)
6+
),
57
indent_character = "\t",
68
style_guide_name = "test",
79
style_guide_version = 1

0 commit comments

Comments
 (0)