remove blank lines in function headers

Author: lorenzwalthert

NEWS.md

@@ -2,6 +2,7 @@
 
 ## Major changes
 
+- blank lines in function calls and headers are now removed (#629, #630).
 
 ## Minor chnages and fixes
 
@@ -10,7 +11,6 @@
 - typos in documentation (#618, #614).
 
 
-
 # styler 1.3.2
 
 Release upon request by the CRAN team.
@@ -435,4 +435,3 @@ specify_reindention(
 )
 initialize_default_attributes(pd_flat)
 ```
-

R/rules-line-break.R

@@ -170,9 +170,10 @@ remove_line_break_before_round_closing_after_curly <- function(pd) {
   pd
 }
 
-remove_line_break_before_round_closing_fun_dec <- function(pd) {
+remove_line_breaks_in_fun_dec <- function(pd) {
   if (is_function_dec(pd)) {
     round_after <- pd$token == "')'" & pd$token_before != "COMMENT"
+    pd$lag_newlines[pd$lag_newlines > 1L] <- 1L
     pd$lag_newlines[round_after] <- 0L
   }
   pd

R/style-guides.R

@@ -117,8 +117,8 @@ tidyverse_style <- function(scope = "tokens",
       set_line_break_before_curly_opening,
       remove_line_break_before_round_closing_after_curly =
         if (strict) remove_line_break_before_round_closing_after_curly,
-      remove_line_break_before_round_closing_fun_dec =
-        if (strict) remove_line_break_before_round_closing_fun_dec,
+      remove_line_breaks_in_fun_dec =
+        if (strict) remove_line_breaks_in_fun_dec,
       style_line_break_around_curly = partial(
         style_line_break_around_curly,
         strict

tests/testthat/fun_dec/line_break_fun_dec-in.R

@@ -1,6 +1,5 @@
 a <- function(x, #
-              y
-              ) {
+              y) {
   x - 1
 }
 
@@ -13,6 +12,24 @@ a <- function(x, #
 
 a <- function(x, #
               y #
-            ) {
+) {
   y
 }
+
+
+a <- function(x,
+              y) {
+  x - 1
+}
+
+a <- function(x,
+              #
+              y) {
+  x - 1
+}
+
+a <- function(x,
+
+              y) {
+  x - 1
+}

tests/testthat/fun_dec/line_break_fun_dec-in_tree

@@ -15,3 +15,20 @@ a <- function(x, #
 ) {
   y
 }
+
+
+a <- function(x,
+              y) {
+  x - 1
+}
+
+a <- function(x,
+              #
+              y) {
+  x - 1
+}
+
+a <- function(x,
+              y) {
+  x - 1
+}