Use cli_abort(), not fail() to signal a duplicate snapshot name was received (test author error)

schloerke · schloerke · commit 0fa3d40273e2 · 2025-07-25T15:30:52.000-04:00
diff --git a/R/snapshot-reporter.R b/R/snapshot-reporter.R
@@ -106,12 +106,8 @@ SnapshotReporter <- R6::R6Class("SnapshotReporter",
 
       save_path <- file.path(snap_dir, name)
       if (save_path %in% self$snap_file_saved) {
-        fail(
-          paste0(
-            "Snapshot file '", name, "' has already been saved.",
-            " Please provide a unique snapshot file name"
-          ),
-          trace_env = trace_env
+        cli::cli_abort(
+          "Snapshot file {.arg name} has already been saved. Please provide a unique snapshot file name."
         )
       }
       self$snap_file_saved <- c(self$snap_file_saved, save_path)

Original file line number	Diff line number	Diff line change
`@@ -106,12 +106,8 @@ SnapshotReporter <- R6::R6Class("SnapshotReporter",`
`106`	`106`
`107`	`107`	`save_path <- file.path(snap_dir, name)`
`108`	`108`	`if (save_path %in% self$snap_file_saved) {`
`109`		`- fail(`
`110`		`- paste0(`
`111`		`- "Snapshot file '", name, "' has already been saved.",`
`112`		`- " Please provide a unique snapshot file name"`
`113`		`- ),`
`114`		`- trace_env = trace_env`
	`109`	`+ cli::cli_abort(`
	`110`	`+ "Snapshot file {.arg name} has already been saved. Please provide a unique snapshot file name."`
`115`	`111`	`)`
`116`	`112`	`}`
`117`	`113`	`self$snap_file_saved <- c(self$snap_file_saved, save_path)`