Elimiante no longer used argument

Author: hadley

R/snapshot-file.R

@@ -160,7 +160,7 @@ expect_snapshot_file <- function(
   if (in_check_reporter()) {
     hint <- ""
   } else {
-    hint <- snapshot_review_hint(file, name, is_text = is_text)
+    hint <- snapshot_review_hint(file, is_text = is_text)
   }
 
   if (!equal) {
@@ -209,24 +209,21 @@ announce_snapshot_file <- function(path, name = basename(path)) {
 
 snapshot_review_hint <- function(
   test,
-  name,
   is_text = FALSE,
   reset_output = TRUE
 ) {
   if (reset_output) {
     local_reporter_output()
   }
 
-  path <- paste0("tests/testthat/_snaps/", test, "/", new_name(name))
-
   c(
     if (is_text) {
       cli::format_inline(
         "* Run {.run testthat::snapshot_accept('{test}/')} to accept the change."
       )
     },
     cli::format_inline(
-      "* Run {.run testthat::snapshot_review('{test}/')} to review changes."
+      "* Run {.run testthat::snapshot_review('{test}/')} to review the change."
     )
   )
 }

tests/testthat/_snaps/snapshot-file.md

@@ -25,10 +25,18 @@
 # generates informative hint
 
     Code
-      cat(snapshot_review_hint("lala", "foo.r", reset_output = FALSE))
+      base::writeLines(snapshot_review_hint("lala", reset_output = FALSE))
     Output
       * Run `testthat::snapshot_review('lala/')` to review changes.
 
+---
+
+    Code
+      base::writeLines(snapshot_review_hint("lala", is_text = TRUE, reset_output = FALSE))
+    Output
+      * Run `testthat::snapshot_accept('lala/')` to accept the change.
+      * Run `testthat::snapshot_review('lala/')` to review changes.
+
 # expect_snapshot_file validates its inputs
 
     Code

tests/testthat/_snaps/snapshot-file.new.md

@@ -0,0 +1,57 @@
+# expect_snapshot_file finds duplicate snapshot files
+
+    Code
+      expect_snapshot_file(write_tmp_lines(r_version()), "version.txt", variant = r_version())
+    Condition
+      Error in `expect_snapshot_file()`:
+      ! Snapshot file names must be unique. `name` has already been used.
+
+# warns on first creation
+
+    Code
+      out <- snapshot_file_equal_(path)
+    Condition
+      Warning:
+      Adding new file snapshot: 'tests/testthat/_snaps/my-test/test.txt'
+
+---
+
+    Code
+      snapshot_file_equal_("doesnt-exist.txt")
+    Condition
+      Error in `snapshot_file_equal_()`:
+      ! 'doesnt-exist.txt' not found.
+
+# generates informative hint
+
+    Code
+      base::writeLines(snapshot_review_hint("lala", reset_output = FALSE))
+    Output
+      * Run `testthat::snapshot_review('lala/')` to review the change.
+
+---
+
+    Code
+      base::writeLines(snapshot_review_hint("lala", is_text = TRUE, reset_output = FALSE))
+    Output
+      * Run `testthat::snapshot_accept('lala/')` to accept the change.
+      * Run `testthat::snapshot_review('lala/')` to review the change.
+
+# expect_snapshot_file validates its inputs
+
+    Code
+      expect_snapshot_file(123, "test.txt")
+    Condition
+      Error in `expect_snapshot_file()`:
+      ! `path` must be a single string, not the number 123.
+    Code
+      expect_snapshot_file("test.txt", 123)
+    Condition
+      Error in `expect_snapshot_file()`:
+      ! `name` must be a single string, not the number 123.
+    Code
+      expect_snapshot_file("test.txt", "test.txt", cran = "yes")
+    Condition
+      Error in `expect_snapshot_file()`:
+      ! `cran` must be `TRUE` or `FALSE`, not the string "yes".
+

tests/testthat/test-snapshot-file.R

@@ -163,9 +163,14 @@ test_that("split_path handles edge cases", {
 })
 
 test_that("generates informative hint", {
-  expect_snapshot(cat(snapshot_review_hint(
+  expect_snapshot(base::writeLines(snapshot_review_hint(
     "lala",
-    "foo.r",
+    reset_output = FALSE
+  )))
+
+  expect_snapshot(base::writeLines(snapshot_review_hint(
+    "lala",
+    is_text = TRUE,
     reset_output = FALSE
   )))
 })