Skip to content

Commit 21939e2

Browse files
committed
In CheckReporter, only show repeated summary if needed
Part of #1543
1 parent acfae29 commit 21939e2

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

R/reporter-check.R

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,15 @@ CheckReporter <- R6::R6Class("CheckReporter",
3535
},
3636

3737
end_reporter = function() {
38-
self$cat_line(summary_line(
39-
n_fail = self$problems$size(),
40-
n_warn = self$warnings$size(),
41-
n_skip = self$skips$size(),
42-
n_pass = self$n_ok
43-
))
44-
self$cat_line()
38+
if (self$skips$size() || self$warnings$size() || self$problems$size()) {
39+
self$cat_line(summary_line(
40+
n_fail = self$problems$size(),
41+
n_warn = self$warnings$size(),
42+
n_skip = self$skips$size(),
43+
n_pass = self$n_ok
44+
))
45+
self$cat_line()
46+
}
4547

4648
if (self$skips$size() > 0) {
4749
self$rule("Skipped tests", line = 2)

tests/testthat/_snaps/reporter-check.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@
5252
# always shows summary
5353

5454
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 7 ]
55-
56-
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 7 ]
5755

5856
# shows warnings when not on CRAN
5957

0 commit comments

Comments
 (0)