Include test path in snaphot hints

If you're not testing the current directory/package.

Fixes #1577

Author: hadley

R/local.R

@@ -177,14 +177,15 @@ local_test_directory <- function(path, package = NULL, .env = parent.frame()) {
   # Set edition before changing working directory in case path is relative
   local_edition(find_edition(path, package), .env = .env)
 
-  withr::local_dir(
-    path,
-    .local_envir = .env
-  )
+  # Capture current working directory so we can use for relative paths
+  wd <- getwd()
+
+  withr::local_dir(path, .local_envir = .env)
   withr::local_envvar(
     R_TESTS = "",
     TESTTHAT = "true",
     TESTTHAT_PKG = package,
+    TESTTHAT_WD = wd,
     .local_envir = .env
   )
 }

R/snapshot.R

@@ -364,13 +364,23 @@ snapshot_accept_hint <- function(variant, file, reset_output = TRUE) {
     name <- file.path(variant, file)
   }
 
+  args <- encodeString(name, quote = '"')
+  # Include path argument if we're in a different working directory
+  wd <- Sys.getenv("TESTTHAT_WD", unset = "")
+  if (wd != "") {
+    test_path <- file.path(wd, "tests/testthat")
+    if (test_path != getwd()) {
+      args <- paste0(args, ", ", encodeString(getwd(), quote = '"'))
+    }
+  }
+
   paste0(
     cli::format_inline(
-      "* Run {.run testthat::snapshot_accept('{name}')} to accept the change."
+      "* Run {.run testthat::snapshot_accept({args})} to accept the change."
     ),
     "\n",
     cli::format_inline(
-      "* Run {.run testthat::snapshot_review('{name}')} to interactively review the change."
+      "* Run {.run testthat::snapshot_review({args})} to interactively review the change."
     )
   )
 }

tests/testthat/_snaps/snapshot.md

@@ -258,13 +258,13 @@
     Code
       cat(snapshot_accept_hint("_default", "bar.R", reset_output = FALSE))
     Output
-      * Run ]8;;ide:run:testthat::snapshot_accept('bar.R')testthat::snapshot_accept('bar.R')]8;; to accept the change.
-      * Run ]8;;ide:run:testthat::snapshot_review('bar.R')testthat::snapshot_review('bar.R')]8;; to interactively review the change.
+      * Run ]8;;ide:run:testthat::snapshot_accept("bar.R")testthat::snapshot_accept("bar.R")]8;; to accept the change.
+      * Run ]8;;ide:run:testthat::snapshot_review("bar.R")testthat::snapshot_review("bar.R")]8;; to interactively review the change.
     Code
       cat(snapshot_accept_hint("foo", "bar.R", reset_output = FALSE))
     Output
-      * Run ]8;;ide:run:testthat::snapshot_accept('foo/bar.R')testthat::snapshot_accept('foo/bar.R')]8;; to accept the change.
-      * Run ]8;;ide:run:testthat::snapshot_review('foo/bar.R')testthat::snapshot_review('foo/bar.R')]8;; to interactively review the change.
+      * Run ]8;;ide:run:testthat::snapshot_accept("foo/bar.R")testthat::snapshot_accept("foo/bar.R")]8;; to accept the change.
+      * Run ]8;;ide:run:testthat::snapshot_review("foo/bar.R")testthat::snapshot_review("foo/bar.R")]8;; to interactively review the change.
 
 # expect_snapshot validates its inputs
 

tests/testthat/test-snapshot.R

@@ -174,6 +174,15 @@ test_that("hint is informative", {
   })
 })
 
+test_that("hint includes path when WD is different", {
+  withr::local_envvar(TESTTHAT_WD = "..")
+
+  hint <- snapshot_accept_hint("_default", "bar.R", reset_output = FALSE)
+  hint <- gsub(getwd(), "<WD>", hint)
+  # Can't use snapshot here because its hint will get the wrong path
+  expect_match(hint, 'snapshot_accept("bar.R", "<WD>")', fixed = TRUE)
+})
+
 test_that("expect_snapshot requires a non-empty test label", {
   local_description_set()