Feedback for claude

Author: hadley

R/mock-oo.R

@@ -2,7 +2,7 @@
 #'
 #' These functions allow you to temporarily override S3 and S4 methods that
 #' already exist. It works by using [registerS3method()]/[setMethod()] to
-#' temporarily replace the original defintion.
+#' temporarily replace the original definition.
 #'
 #' @param generic A string giving the name of the generic.
 #' @param signature A character vector giving the signature of the method.
@@ -83,12 +83,15 @@ local_mocked_r6_class <- function(
   if (!inherits(class, "R6ClassGenerator")) {
     stop_input_type(class, "an R6 class definition")
   }
+  if (!is.list(public)) {
+    stop_input_type(public, "a list")
+  }
+  if (!is.list(private)) {
+    stop_input_type(private, "a list")
+  }
 
   mocked_class <- mock_r6_class(class, public, private)
-  local_mocked_bindings(
-    "{class$classname}" := mocked_class,
-    .env = caller_env()
-  )
+  local_mocked_bindings("{class$classname}" := mocked_class, .env = frame)
 }
 
 mock_r6_class <- function(class, public = list(), private = list()) {

man/local_mocked_s3_method.Rd

@@ -44,3 +44,21 @@
       Error in `local_mocked_s4_method()`:
       ! Can't find existing S4 method `mean(bar)`.
 
+---
+
+    Code
+      local_mocked_r6_class(mean)
+    Condition
+      Error in `local_mocked_r6_class()`:
+      ! `class` must be an R6 class definition, not a function.
+    Code
+      local_mocked_r6_class(TestMockClass, public = 1)
+    Condition
+      Error in `local_mocked_r6_class()`:
+      ! `public` must be a list, not the number 1.
+    Code
+      local_mocked_r6_class(TestMockClass, private = 1)
+    Condition
+      Error in `local_mocked_r6_class()`:
+      ! `private` must be a list, not the number 1.
+

tests/testthat/_snaps/mock-oo.md

@@ -65,3 +65,11 @@ test_that("can mock all R6 components", {
   obj <- TestMockClass$new()
   expect_equal(obj$sum(), 0)
 })
+
+test_that("validates its inputs", {
+  expect_snapshot(error = TRUE, {
+    local_mocked_r6_class(mean)
+    local_mocked_r6_class(TestMockClass, public = 1)
+    local_mocked_r6_class(TestMockClass, private = 1)
+  })
+})