Pass ... from snapshot_review() to shiny::runApp()

Fixes #1928

Author: hadley

NEWS.md

@@ -1,5 +1,6 @@
 # testthat (development version)
 
+* `snapshot_review()` now passes `...` on to `shiny::runApp()` (#1928).
 * `expect_named()` now gives more informative errors (#2091).
 * `expect_*()` functions consistently and rigorously check their inputs (#1754). 
 * `test_that()` no longer warns about the absence of `{}` since it no longer seems to be necessary.

R/snapshot-manage.R

@@ -44,8 +44,9 @@ snapshot_reject <- function(files = NULL, path = "tests/testthat") {
 }
 
 #' @rdname snapshot_accept
+#' @param ... Additional arguments passed on to [shiny::runApp()].
 #' @export
-snapshot_review <- function(files = NULL, path = "tests/testthat") {
+snapshot_review <- function(files = NULL, path = "tests/testthat", ...) {
   check_installed(c("shiny", "diffviewer"), "to use snapshot_review()")
 
   changed <- snapshot_meta(files, path)
@@ -54,12 +55,12 @@ snapshot_review <- function(files = NULL, path = "tests/testthat") {
     return(invisible())
   }
 
-  review_app(changed$name, changed$cur, changed$new)
+  review_app(changed$name, changed$cur, changed$new, ...)
   rstudio_tickle()
   invisible()
 }
 
-review_app <- function(name, old_path, new_path) {
+review_app <- function(name, old_path, new_path, ...) {
   stopifnot(
     length(name) == length(old_path),
     length(old_path) == length(new_path)
@@ -147,7 +148,8 @@ review_app <- function(name, old_path, new_path) {
   shiny::runApp(
     shiny::shinyApp(ui, server),
     quiet = TRUE,
-    launch.browser = shiny::paneViewer()
+    launch.browser = shiny::paneViewer(),
+    ...
   )
   invisible()
 }