Merged origin/main into new-snapshot-fail-on-ci

Author: hadley

tests/testthat/_snaps/describe.md

@@ -1,3 +1,17 @@
+# snapshot tests in describe
+
+    Code
+      1 + 1
+    Output
+      [1] 2
+
+# snapshot tests in describe / and in it
+
+    Code
+      1 + 1
+    Output
+      [1] 2
+
 # has to have a valid description for the block
 
     Code

tests/testthat/_snaps/snapshot.md

@@ -258,13 +258,13 @@
     Code
       cat(snapshot_accept_hint("_default", "bar.R", reset_output = FALSE))
     Output
-      * Run ]8;;ide:run:testthat::snapshot_accept('bar.R')testthat::snapshot_accept('bar.R')]8;; to accept the change.
-      * Run ]8;;ide:run:testthat::snapshot_review('bar.R')testthat::snapshot_review('bar.R')]8;; to interactively review the change.
+      * Run `testthat::snapshot_accept('bar.R')` to accept the change.
+      * Run `testthat::snapshot_review('bar.R')` to interactively review the change.
     Code
       cat(snapshot_accept_hint("foo", "bar.R", reset_output = FALSE))
     Output
-      * Run ]8;;ide:run:testthat::snapshot_accept('foo/bar.R')testthat::snapshot_accept('foo/bar.R')]8;; to accept the change.
-      * Run ]8;;ide:run:testthat::snapshot_review('foo/bar.R')testthat::snapshot_review('foo/bar.R')]8;; to interactively review the change.
+      * Run `testthat::snapshot_accept('foo/bar.R')` to accept the change.
+      * Run `testthat::snapshot_review('foo/bar.R')` to interactively review the change.
 
 # expect_snapshot validates its inputs
 

tests/testthat/test-describe.R

@@ -13,6 +13,17 @@ describe("describe", {
   })
 })
 
+test_that("can write snaphot tests", {
+  local_description_set()
+
+  describe("snapshot tests in describe", {
+    expect_snapshot(1 + 1)
+    it("and in it", {
+      expect_snapshot(1 + 1)
+    })
+  })
+})
+
 test_that("unimplemented specs generate skips", {
   expectations <- capture_expectations({
     it("can have not yet implemented specs", {

tests/testthat/test-snapshot.R

@@ -166,8 +166,6 @@ test_that("errors and warnings are folded", {
 # })
 
 test_that("hint is informative", {
-  local_reproducible_output(crayon = TRUE, hyperlinks = TRUE, rstudio = TRUE)
-
   expect_snapshot({
     cat(snapshot_accept_hint("_default", "bar.R", reset_output = FALSE))
     cat(snapshot_accept_hint("foo", "bar.R", reset_output = FALSE))